Merge lp:~sylvain-pineau/checkbox/fix-1561821 into lp:checkbox
Proposed by
Sylvain Pineau
Status: | Merged |
---|---|
Approved by: | Sylvain Pineau |
Approved revision: | 4290 |
Merged at revision: | 4290 |
Proposed branch: | lp:~sylvain-pineau/checkbox/fix-1561821 |
Merge into: | lp:checkbox |
Diff against target: |
68 lines (+11/-4) 3 files modified
plainbox/plainbox/impl/unit/template.py (+11/-0) providers/plainbox-provider-checkbox/jobs/input.txt.in (+0/-2) providers/plainbox-provider-checkbox/jobs/suspend.txt.in (+0/-2) |
To merge this branch: | bzr merge lp:~sylvain-pineau/checkbox/fix-1561821 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Pierre Equoy | Approve | ||
Sylvain Pineau (community) | Needs Resubmitting | ||
Review via email: mp+290320@code.launchpad.net |
Description of the change
Fixes the linked bug, but without modifying the udev parser to add an extra input-id field.
To post a comment you must log in.
It's very smart!
When I was testing it and checking how it worked, I realized there are other jobs where we need to remove the {path} parameter in the description or else it will fail the same way:
- suspend/ pointing- after-suspend_ {product_ slug}_{ category} _{__index_ _} clicking- after-suspend_ {product_ slug}_{ category} _{__index_ _}
- suspend/
Other than that, it looks great. Thanks!