lp:~sylvain-pineau/checkbox/fix-1561821

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 4290

Pierre Equoy: Approve on 2016-03-30

Sylvain Pineau (community): Needs Resubmitting on 2016-03-30

Diff: 68 lines (+11/-4)

3 files modified

plainbox/plainbox/impl/unit/template.py (+11/-0)
providers/plainbox-provider-checkbox/jobs/input.txt.in (+0/-2)
providers/plainbox-provider-checkbox/jobs/suspend.txt.in (+0/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1561821: Plainbox session can't be resumed if plugged in devices (e.g. mice) have been replugged/changed

High

Fix Released

Link a bug report

Related blueprints

4290. By Sylvain Pineau on 2016-03-30

providers:checkbox: Remove {path} requirement in input jobs

As those may change if the same device is unplugged/re-plugged
(even on the same port).

4289. By Sylvain Pineau on 2016-03-29

plainbox:unit:template: Only pass parameters actually used during instantiations

In [1], we found that with the template units, if the user unplugs and replugs
input devices (mice, keyboards) before resuming a session, plainbox will crash.

This is because the device path is changed, so plainbox generates a new job for
the supposedly new device, but since it's the same, it ends up using an
identical job ID, which raises an exception.

Limiting the parameters to a subset that is actually being used during the
template instantiations avoids the DependencyDuplicateError exception.
Note the problem can be easily reproduced if the job definition contains
explicitly the udev {path} parameter for input devices.

[1] https://bugs.launchpad.net/bugs/1561821

4288. By Sylvain Pineau on 2016-03-28

"automatic merge of lp:~sylvain-pineau/checkbox/fix-1560870/ by tarmac [r=sylvain-pineau][bug=1560870][author=sylvain-pineau]"

4287. By Launchpad Translations on behalf of checkbox-dev on 2016-03-27

Launchpad automatic translations update.

4286. By Pierre Equoy on 2016-03-24

"automatic merge of lp:~pierre-equoy/checkbox/fix-missing-precise-dependency-module-init-tools/ by tarmac [r=sylvain-pineau][bug=][author=pierre-equoy]"

4285. By Launchpad Translations on behalf of checkbox-dev on 2016-03-24

Launchpad automatic translations update.

4284. By Launchpad Translations on behalf of checkbox-dev on 2016-03-23

Launchpad automatic translations update.

4283. By Maciej Kisielewski on 2016-03-22

"automatic merge of lp:~kissiel/checkbox/fix-1560198-environ-in-launchers/ by tarmac [r=sylvain-pineau][bug=1560198][author=kissiel]"

4282. By Jeff Lane  on 2016-03-21

"automatic merge of lp:~bladernr/checkbox/1560083-inconsistent-job-display-names/ by tarmac [r=bladernr,pwlars][bug=1560083][author=bladernr]"

4281. By Rod Smith on 2016-03-21

"automatic merge of lp:~rodsmith/checkbox/fix-smart-not-running/ by tarmac [r=bladernr][bug=1560123][author=rodsmith]"