Merge lp:~superm1/ubuntu/natty/grub2/chinese-support into lp:~ubuntu-core-dev/ubuntu/natty/grub2/natty

Proposed by Mario Limonciello
Status: Needs review
Proposed branch: lp:~superm1/ubuntu/natty/grub2/chinese-support
Merge into: lp:~ubuntu-core-dev/ubuntu/natty/grub2/natty
Diff against target: 38 lines (+15/-0)
3 files modified
debian/changelog (+1/-0)
debian/patches/series (+1/-0)
debian/patches/ubuntu_chinese.patch (+13/-0)
To merge this branch: bzr merge lp:~superm1/ubuntu/natty/grub2/chinese-support
Reviewer Review Type Date Requested Status
Colin Watson Needs Fixing
Review via email: mp+43023@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Applying this patch directly would break most other languages. For example, the French locale file is /boot/grub/locale/fr.mo, but LANG is typically something like fr_FR.UTF-8.

I think the best approach is probably, in addition to this, to modify GRUB's gettext module to try stripping off the _CC part itself if ll_CC.mo and ll_CC.mo.gz don't exist. I'm happy to look into this upstream.

review: Needs Fixing
Revision history for this message
Colin Watson (cjwatson) wrote :

Unmerged revisions

2083. By Mario Limonciello

Make sure that the language is set properly in grub.cfg. (LP: #686788)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-12-04 00:02:31 +0000
+++ debian/changelog 2010-12-07 22:55:48 +0000
@@ -3,6 +3,7 @@
3 * grub-mkrescue efi amd64 images:3 * grub-mkrescue efi amd64 images:
4 When searching for .disk/info, set the 'root' parameter as the regular4 When searching for .disk/info, set the 'root' parameter as the regular
5 search requires the variable being set as an argument.5 search requires the variable being set as an argument.
6 * Make sure that the language is set properly in grub.cfg. (LP: #686788)
67
7 -- Mario Limonciello <Mario_Limonciello@Dell.com> Fri, 03 Dec 2010 13:51:19 -06008 -- Mario Limonciello <Mario_Limonciello@Dell.com> Fri, 03 Dec 2010 13:51:19 -0600
89
910
=== modified file 'debian/patches/series'
--- debian/patches/series 2010-11-26 13:05:58 +0000
+++ debian/patches/series 2010-12-07 22:55:48 +0000
@@ -34,3 +34,4 @@
34ubuntu_debug_acpi_shutdown.patch34ubuntu_debug_acpi_shutdown.patch
35ubuntu_fix_usb_efi_boot.patch35ubuntu_fix_usb_efi_boot.patch
36ubuntu_linux_submenus.patch36ubuntu_linux_submenus.patch
37ubuntu_chinese.patch
3738
=== added file 'debian/patches/ubuntu_chinese.patch'
--- debian/patches/ubuntu_chinese.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/ubuntu_chinese.patch 2010-12-07 22:55:48 +0000
@@ -0,0 +1,13 @@
1Index: grub2/util/grub.d/00_header.in
2===================================================================
3--- grub2.orig/util/grub.d/00_header.in 2010-12-07 16:46:53.360590266 -0600
4+++ grub2/util/grub.d/00_header.in 2010-12-07 16:47:36.880121391 -0600
5@@ -23,7 +23,7 @@
6 exec_prefix=@exec_prefix@
7 libdir=@libdir@
8 locale_dir=`echo ${GRUB_PREFIX}/locale | sed ${transform}`
9-grub_lang=`echo $LANG | cut -d _ -f 1`
10+grub_lang=`echo $LANG | cut -d . -f 1`
11
12 . ${libdir}/grub/grub-mkconfig_lib
13

Subscribers

People subscribed via source and target branches