Code review comment for lp:~superm1/ubuntu/natty/grub2/chinese-support

Revision history for this message
Colin Watson (cjwatson) wrote :

Applying this patch directly would break most other languages. For example, the French locale file is /boot/grub/locale/fr.mo, but LANG is typically something like fr_FR.UTF-8.

I think the best approach is probably, in addition to this, to modify GRUB's gettext module to try stripping off the _CC part itself if ll_CC.mo and ll_CC.mo.gz don't exist. I'm happy to look into this upstream.

review: Needs Fixing

« Back to merge proposal