Merge lp:~stub/launchpad/pgbouncer-fixture-noca into lp:launchpad
Proposed by
Stuart Bishop
Status: | Merged |
---|---|
Approved by: | Stuart Bishop |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13863 |
Proposed branch: | lp:~stub/launchpad/pgbouncer-fixture-noca |
Merge into: | lp:launchpad |
Prerequisite: | lp:~stub/launchpad/pgbouncer-fixture |
Diff against target: |
126 lines (+74/-5) 2 files modified
lib/lp/testing/fixture.py (+16/-3) lib/lp/testing/tests/test_fixture.py (+58/-2) |
To merge this branch: | bzr merge lp:~stub/launchpad/pgbouncer-fixture-noca |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gavin Panella (community) | Approve | ||
Review via email: mp+73525@code.launchpad.net |
Commit message
[r=jtv,
Description of the change
= Summary =
PGBouncerFixture would not work in layers without the Component Architecture loaded, such as DatabaseLayer, because it would attempt to reset the Storm Stores and these were not registered.
== Proposed fix ==
Only reset the Storm Stores if they are registered with the Component Architecture.
To post a comment you must log in.
Looks good.
[1]
You might find assertTrue to be a prettier synonym for assert_
(alternatively, both are synonyms for failUnless).
[2]
+ def is_db_available (self):
Could this method be useful elsewhere? If so, the effort to extract it
into a matcher might be worth it.