Code review comment for lp:~stub/launchpad/pgbouncer-fixture-noca

Revision history for this message
Gavin Panella (allenap) wrote :

Looks good.

[1]

You might find assertTrue to be a prettier synonym for assert_
(alternatively, both are synonyms for failUnless).

[2]

+ def is_db_available(self):

Could this method be useful elsewhere? If so, the effort to extract it
into a matcher might be worth it.

review: Approve

« Back to merge proposal