Code review comment for lp:~stub/launchpad/db-deploy

Revision history for this message
Abel Deuring (adeuring) wrote :

Looks good.

+ def add_sql(sql):
+ sql = sql.strip()
+ if sql != '':
+ assert sql.endswith(';'), "SQL fragment not terminated with ';'"

 I'm wondering it if makes sense to add the statement(s)triggering the assert to the error message.

review: Approve (code)

« Back to merge proposal