Merge lp:~stub/launchpad/db-deploy into lp:launchpad
Proposed by
Stuart Bishop
Status: | Merged | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Stuart Bishop | ||||||||||||||||||||
Approved revision: | no longer in the source branch. | ||||||||||||||||||||
Merged at revision: | 14433 | ||||||||||||||||||||
Proposed branch: | lp:~stub/launchpad/db-deploy | ||||||||||||||||||||
Merge into: | lp:launchpad | ||||||||||||||||||||
Diff against target: |
271 lines (+108/-51) 2 files modified
database/schema/security.cfg (+1/-1) database/schema/upgrade.py (+107/-50) |
||||||||||||||||||||
To merge this branch: | bzr merge lp:~stub/launchpad/db-deploy | ||||||||||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Review via email: mp+84231@code.launchpad.net |
Commit message
[r=adeuring][no-qa] Record bzr branch details when applying database updates
Description of the change
Record bzr branch details when applying database updates
To post a comment you must log in.
Looks good.
+ def add_sql(sql):
+ sql = sql.strip()
+ if sql != '':
+ assert sql.endswith(';'), "SQL fragment not terminated with ';'"
I'm wondering it if makes sense to add the statement( s)triggering the assert to the error message.