Code review comment for lp:~stuart-lumgair/dosage/stuarts_plugins

Revision history for this message
Tristan Seligmann (mithrandi) wrote :

There are a bunch of pyflakes warnings in this branch (although actually the ones in dosage/plugins/z.py are my fault). Could you fix these?

dosage/plugins/d.py:3: 'queryNamer' imported but unused
dosage/plugins/drunkduck.py:4: 'getQueryParams' imported but unused
dosage/plugins/z.py:1: 'urllib' imported but unused
dosage/plugins/z.py:4: 'indirectStarter' imported but unused
tools/comicgenesis_base_list_scraper.0.0.13.py:153: local variable 'templst' is assigned to but never used
tools/dd_base_tester.0.0.1.py:5: 'urllib' imported but unused
tools/dd_base_tester.0.0.1.py:6: 'string' imported but unused
tools/drunkduck_base_list_scraper.0.0.2.py:6: 'string' imported but unused
tools/drunkduck_base_list_scraper.0.0.2.py:87: undefined name 'pages'
tools/drunkduck_base_list_scraper.0.0.2.py:89: undefined name 'pages'
tools/drunkduck_base_list_scraper.0.0.3.py:6: 'string' imported but unused
tools/drunkduck_base_list_scraper.0.0.3.py:106: undefined name 'pages'
tools/drunkduck_base_list_scraper.0.0.3.py:108: undefined name 'pages'
tools/remove_comments.py:7: 'os' imported but unused
tools/remove_comments.py:8: 'sys' imported but unused
tools/remove_comments.py:9: 'string' imported but unused
tools/remove_comments.py:16: undefined name 'true'

They're mostly unused imports or variables, but it looks like there may be some buggy code as well (see all the "undefined name" warnings).

Other than that, this looks great!

review: Needs Fixing

« Back to merge proposal