Ubuntu

Merge lp:~straemer/ubuntu/quantal/unity-webapps-reddit/fix-for-1059882 into lp:ubuntu/quantal/unity-webapps-reddit

Proposed by Stephen Kraemer on 2013-03-02
Status: Rejected
Rejected by: Daniel T Chen on 2013-06-18
Proposed branch: lp:~straemer/ubuntu/quantal/unity-webapps-reddit/fix-for-1059882
Merge into: lp:ubuntu/quantal/unity-webapps-reddit
Diff against target: 31 lines (+10/-3) 2 files modified
To merge this branch: bzr merge lp:~straemer/ubuntu/quantal/unity-webapps-reddit/fix-for-1059882
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Resubmit on 2013-05-18
Daniel T Chen 2013-03-02 Needs Information on 2013-03-29
Review via email: mp+151347@code.launchpad.net

Description of the Change

To post a comment you must log in.
3. By Stephen Kraemer on 2013-03-02

Reddit.user.js have inbox option always show, without always being highlit.

Stephen Kraemer (straemer) wrote :

Note that revision 3 will change the behaviour a bit: the "Inbox" indicator will always show. The number of unread messages will be set to 0 or 1, since I couldn't find anything to actually get a count of the number of messages. It will be 1 if there is at least 1 unread message.

Daniel T Chen (crimsun) wrote :

From the original bug report:
"2) See envelope in indicator bar turn blue only if there are some new messages, stay gray if there aren't."

Does your proposed change meet this criterion? What additional changes, if any, are there?

review: Needs Information
Stephen Kraemer (straemer) wrote :

Yes, it does meet this criterion. This changes it from always being highlit (indicating new messages) when reddit is opened to only being highlit when new messages are actually available. I documented this in Bug #1061307, although this patch doesn't completely fix that bug, so I didn't link the two together.

Robert Bruce Park (robru) wrote :

Confirmed, with patch applied, the messaging menu does not get highlighted when reddit is open.

This is not the correct place for this MP though, so I've resubmitted it here:

https://code.launchpad.net/~robru/unity-webapps-reddit/lp-1059882/+merge/164559

review: Resubmit

Unmerged revisions

3. By Stephen Kraemer on 2013-03-02

Reddit.user.js have inbox option always show, without always being highlit.

2. By Stephen Kraemer on 2013-03-02

Reddit.user.js fix for mail icon always being highlit (LP: #1059882)

Preview Diff

1=== modified file 'Reddit.user.js'
2--- Reddit.user.js 2012-09-18 18:40:42 +0000
3+++ Reddit.user.js 2013-03-02 18:08:20 +0000
4@@ -8,9 +8,9 @@
5 window.Unity = external.getUnityObject(1);
6
7 function setupIndicators() {
8- if (!document.getElementsByClassName("havemail")[0]) {
9- Unity.MessagingIndicator.showIndicator(_("Inbox"), {time: new Date()});
10- }
11+ Unity.MessagingIndicator.showIndicator(_("Inbox"), {
12+ count: document.getElementsByClassName("havemail")[0] != undefined
13+ });
14
15 Unity.MessagingIndicator.addAction(_("Compose New Message"),
16 makeRedirector("http://www.reddit.com/message/compose/"));
17
18=== modified file 'debian/changelog'
19--- debian/changelog 2012-09-18 18:40:42 +0000
20+++ debian/changelog 2013-03-02 18:08:20 +0000
21@@ -1,3 +1,10 @@
22+unity-webapps-reddit (2.2ubuntu2) UNRELEASED; urgency=low
23+
24+ * Reddit.user.js fix for mail icon always being highlit (LP: #1059882)
25+ * Reddit.user.js have inbox option always show, without always being highlit.
26+
27+ -- Stephen Kraemer <straemer@gmail.com> Sat, 02 Mar 2013 13:04:25 -0500
28+
29 unity-webapps-reddit (2.2) quantal; urgency=low
30
31 * Initial release

Subscribers

People subscribed via source and target branches