Merge lp:~straemer/ubuntu/quantal/unity-webapps-reddit/fix-for-1059882 into lp:ubuntu/quantal/unity-webapps-reddit

[Stephen Kraemer]

Fix for mail icon always being highlit see https://bugs.launchpad.net/ubuntu/+source/unity-webapps-reddit/+bug/1059882

[lp:~straemer/ubuntu/quantal/unity-webapps-reddit/fix-for-1059882]

3. By Stephen Kraemer on 2013-03-02

Reddit.user.js have inbox option always show, without always being highlit.

[Stephen Kraemer (straemer)]

Note that revision 3 will change the behaviour a bit: the "Inbox" indicator will always show. The number of unread messages will be set to 0 or 1, since I couldn't find anything to actually get a count of the number of messages. It will be 1 if there is at least 1 unread message.

[Daniel T Chen (crimsun)]

From the original bug report:
"2) See envelope in indicator bar turn blue only if there are some new messages, stay gray if there aren't."

Does your proposed change meet this criterion? What additional changes, if any, are there?

review: Needs Information

[Stephen Kraemer (straemer)]

Yes, it does meet this criterion. This changes it from always being highlit (indicating new messages) when reddit is opened to only being highlit when new messages are actually available. I documented this in Bug #1061307, although this patch doesn't completely fix that bug, so I didn't link the two together.

[Robert Bruce Park (robru)]

Confirmed, with patch applied, the messaging menu does not get highlighted when reddit is open.

This is not the correct place for this MP though, so I've resubmitted it here:

https://code.launchpad.net/~robru/unity-webapps-reddit/lp-1059882/+merge/164559

review: Needs Resubmitting

Unmerged revisions

3. By Stephen Kraemer on 2013-03-02

Reddit.user.js have inbox option always show, without always being highlit.

2. By Stephen Kraemer on 2013-03-02

Reddit.user.js fix for mail icon always being highlit (LP: #1059882)

=== modified file 'Reddit.user.js'
--- Reddit.user.js	2012-09-18 18:40:42 +0000
+++ Reddit.user.js	2013-03-02 18:08:20 +0000
@@ -8,9 +8,9 @@
 window.Unity = external.getUnityObject(1);
 
 function setupIndicators() {
-    if (!document.getElementsByClassName("havemail")[0]) {
-        Unity.MessagingIndicator.showIndicator(_("Inbox"), {time: new Date()});
-    }
+    Unity.MessagingIndicator.showIndicator(_("Inbox"), {
+	count: document.getElementsByClassName("havemail")[0] != undefined
+    });
 
     Unity.MessagingIndicator.addAction(_("Compose New Message"),
                                        makeRedirector("http://www.reddit.com/message/compose/"));

=== modified file 'debian/changelog'
--- debian/changelog	2012-09-18 18:40:42 +0000
+++ debian/changelog	2013-03-02 18:08:20 +0000
@@ -1,3 +1,10 @@
+unity-webapps-reddit (2.2ubuntu2) UNRELEASED; urgency=low
+
+  * Reddit.user.js fix for mail icon always being highlit (LP: #1059882)
+  * Reddit.user.js have inbox option always show, without always being highlit.
+
+ -- Stephen Kraemer <[e-mail]>  Sat, 02 Mar 2013 13:04:25 -0500
+
 unity-webapps-reddit (2.2) quantal; urgency=low
 
   * Initial release