Merge lp:~robru/unity-webapps-reddit/lp-1059882 into lp:unity-webapps-reddit

[Robert Bruce Park]

Don't highlight messaging menu when reddit doesn't have messages (thanks to straemer).

Forward-port of lp:~straemer/ubuntu/quantal/unity-webapps-reddit/fix-for-1059882

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:35
http://jenkins.qa.ubuntu.com/job/unity-webapps-reddit-ci/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-reddit-saucy-amd64-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-reddit-saucy-armhf-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-reddit-ci/1/rebuild

review: Needs Fixing (continuous-integration)

[Francis Ginther (fginther)]

Build failed due to attempting to download suacy packages from ppa:webapps/staging before any saucy packages exist. I've manually added a saucy package (for webapps-applications) and we should be able to retry this build when it finishes publishing.

[Víctor R. Ruiz (vrruiz)]

Thanks, Francis!

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:35
http://jenkins.qa.ubuntu.com/job/unity-webapps-reddit-ci/2/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-reddit-saucy-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-reddit-saucy-armhf-ci/2

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-reddit-ci/2/rebuild

review: Approve (continuous-integration)

[Stephen Kraemer (straemer)]

review: Approve

[Stephen Kraemer (straemer)]

What is the status on getting this patch merged in? And is there any chance that it will be merged back into Raring and Quantal as well? It's a pretty annoying bug in this application...

[Stephen Kraemer (straemer)]

Hi, still waiting on an update for this please.

[Francis Ginther (fginther)]

The jenkins issue was resolved some time ago and the ci build passed. I'm abstaining from reviewing the actual fix.

review: Abstain

[Robert Bruce Park (robru)]

We need to hear from either Alex or Victor to get a final approval on this.

[Alexandre Abreu (abreu-alexandre)]

This would work as a quick fix, there is a branch somewhere (that needs a bit of cleanup) that kind of fixes that + other stuff to make reddit a better integrated script:

https://code.launchpad.net/~abreu-alexandre/webapps-applications/fix-reddit-integration-script/+merge/134386

I need to rework it a bit

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-webapps-reddit-autolanding/2/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-reddit-saucy-amd64-autolanding/2/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-reddit-saucy-armhf-autolanding/2/console

review: Needs Fixing (continuous-integration)

[lp:~robru/unity-webapps-reddit/lp-1059882]

36. By Robert Bruce Park on 2013-06-12

Fix style_checker.js warnings.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:36
http://jenkins.qa.ubuntu.com/job/unity-webapps-reddit-ci/4/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-reddit-saucy-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-reddit-saucy-armhf-ci/4

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-reddit-ci/4/rebuild

review: Approve (continuous-integration)

=== modified file 'Reddit.user.js'
--- Reddit.user.js	2013-06-11 17:37:07 +0000
+++ Reddit.user.js	2013-06-12 19:28:26 +0000
@@ -13,9 +13,9 @@
 window.Unity = external.getUnityObject(1);
 
 function setupIndicators() {
-    if (!document.getElementsByClassName("havemail")[0]) {
-        Unity.MessagingIndicator.showIndicator(_("Inbox"), {time: new Date()});
-    }
+    Unity.MessagingIndicator.showIndicator(_("Inbox"), {
+        count: document.getElementsByClassName("havemail")[0] !== undefined
+    });
 
     Unity.MessagingIndicator.addAction(_("Compose New Message"),
                                        makeRedirector("http://www.reddit.com/message/compose/"));