Code review comment for lp:~stolowski/unity8/pkg-version-into-varlib
Revision history for this message
| Paweł Stołowski (stolowski) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> Why does the plugin need that?
>
> Wouldn't be better using a call from unity8-dash to the plugin than a magic
> file somewhere?
Plugin needs version numbers of itself, unity8, unity-scopes-api to send them to smart scopes server. Note, this may change in the future if smart scopes are ever abandoned (they are effectively in maintenence mode now).
In all cases we want real package versions and not artifical numbers (defined somewhere in the code) that would require manual updating. Currently we run dpkg-query during plugin startup, but this was proved to be very slow. The proposed solution is the fastest equivalent of running dpkg-query, without the associated cost. It's also a solution that gives version for all packages we're insterested in (I MP'ed same changes to scopes api and plugin), whereas making a special call for unity8-dash will make it look nicer for the dash only (and still, you need to get this version number in an efficient way somehow to pass it to the plugin).