Merge lp:~stolowski/unity8/pkg-version-into-varlib into lp:unity8
| Status: | Merged |
|---|---|
| Approved by: | Albert Astals Cid on 2015-10-09 |
| Approved revision: | 1980 |
| Merged at revision: | 2002 |
| Proposed branch: | lp:~stolowski/unity8/pkg-version-into-varlib |
| Merge into: | lp:unity8 |
| Diff against target: |
21 lines (+4/-0) 2 files modified
data/CMakeLists.txt (+3/-0) debian/unity8.install (+1/-0) |
| To merge this branch: | bzr merge lp:~stolowski/unity8/pkg-version-into-varlib |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Albert Astals Cid (community) | 2015-09-25 | Approve on 2015-10-09 | |
| PS Jenkins bot | continuous-integration | Needs Fixing on 2015-10-02 | |
|
Review via email:
|
|||
Commit Message
Store unity8 package version in /var/lib/
Description of the Change
* Are there any related MPs required for this MP to build/function as expected? Please list.
N/A
* Did you perform an exploratory manual test run of your code change and any related functionality?
Y
* Did you make sure that your branch does not contain spurious tags?
Y
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Y
* If you changed the UI, has there been a design review?
N/A
| Albert Astals Cid (aacid) wrote : | # |
Please run strip-tags.py over lp:~stolowski/unity8/pkg-version-into-varlib
Also write https:/
| Paweł Stołowski (stolowski) wrote : | # |
> Please run strip-tags.py over lp:~stolowski/unity8/pkg-version-into-varlib
>
> Also write https:/
> description
Ok, done.
| Albert Astals Cid (aacid) wrote : | # |
Why does the plugin need that?
Wouldn't be better using a call from unity8-dash to the plugin than a magic file somewhere?
| Paweł Stołowski (stolowski) wrote : | # |
> Why does the plugin need that?
>
> Wouldn't be better using a call from unity8-dash to the plugin than a magic
> file somewhere?
Plugin needs version numbers of itself, unity8, unity-scopes-api to send them to smart scopes server. Note, this may change in the future if smart scopes are ever abandoned (they are effectively in maintenence mode now).
In all cases we want real package versions and not artifical numbers (defined somewhere in the code) that would require manual updating. Currently we run dpkg-query during plugin startup, but this was proved to be very slow. The proposed solution is the fastest equivalent of running dpkg-query, without the associated cost. It's also a solution that gives version for all packages we're insterested in (I MP'ed same changes to scopes api and plugin), whereas making a special call for unity8-dash will make it look nicer for the dash only (and still, you need to get this version number in an efficient way somehow to pass it to the plugin).
| Albert Astals Cid (aacid) wrote : | # |
Ok, if this means the plugin doesn't need to call dpkg on runtime makes sense to have.
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass?
Yes to the extend they do
* Did you make sure that the branch does not contain spurious tags?
Yes
FAILED: Continuous integration, rev:1980
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://