Merge lp:~stolowski/unity-api/scopes-close-scope into lp:unity-api

Proposed by Paweł Stołowski
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 168
Merged at revision: 169
Proposed branch: lp:~stolowski/unity-api/scopes-close-scope
Merge into: lp:unity-api
Diff against target: 63 lines (+15/-1)
5 files modified
debian/changelog (+6/-0)
include/unity/shell/scopes/CMakeLists.txt (+1/-1)
include/unity/shell/scopes/ScopesInterface.h (+2/-0)
test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScopes.cpp (+5/-0)
test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScopes.h (+1/-0)
To merge this branch: bzr merge lp:~stolowski/unity-api/scopes-close-scope
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
Review via email: mp+248725@code.launchpad.net

Commit message

Added Scopes::closeScope abstract method.

Description of the change

To post a comment you must log in.
Revision history for this message
Albert Astals Cid (aacid) wrote :

Looks good.

review: Approve
Revision history for this message
Albert Astals Cid (aacid) wrote :

Actually doesn't even build :D

review: Needs Fixing
168. By Paweł Stołowski

Ups, added closeScope method to the mock.

Revision history for this message
Albert Astals Cid (aacid) :
review: Approve
169. By Paweł Stołowski

Merged trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2015-02-11 16:28:29 +0000
+++ debian/changelog 2015-02-12 17:18:49 +0000
@@ -1,3 +1,9 @@
1unity-api (7.96-0ubuntu1) UNRELEASED; urgency=medium
2
3 * Added close method to scopes interface.
4
5 -- Pawel Stolowski <pawel@mordor> Thu, 12 Feb 2015 18:17:42 +0100
6
1unity-api (7.95+15.04.20150211-0ubuntu1) vivid; urgency=medium7unity-api (7.95+15.04.20150211-0ubuntu1) vivid; urgency=medium
28
3 [ Michael Zanetti ]9 [ Michael Zanetti ]
410
=== modified file 'include/unity/shell/scopes/CMakeLists.txt'
--- include/unity/shell/scopes/CMakeLists.txt 2014-10-20 20:45:26 +0000
+++ include/unity/shell/scopes/CMakeLists.txt 2015-02-12 17:18:49 +0000
@@ -7,7 +7,7 @@
77
8set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)8set(UNITY_API_LIB_HDRS ${UNITY_API_LIB_HDRS} ${headers} ${internal_headers} PARENT_SCOPE)
99
10set(VERSION 5)10set(VERSION 6)
11set(PKGCONFIG_NAME "unity-shell-scopes")11set(PKGCONFIG_NAME "unity-shell-scopes")
12set(PKGCONFIG_DESCRIPTION "Unity shell Scopes APIs")12set(PKGCONFIG_DESCRIPTION "Unity shell Scopes APIs")
13set(PKGCONFIG_REQUIRES "Qt5Core")13set(PKGCONFIG_REQUIRES "Qt5Core")
1414
=== modified file 'include/unity/shell/scopes/ScopesInterface.h'
--- include/unity/shell/scopes/ScopesInterface.h 2014-10-22 15:23:38 +0000
+++ include/unity/shell/scopes/ScopesInterface.h 2015-02-12 17:18:49 +0000
@@ -112,6 +112,8 @@
112 }112 }
113 // @endcond113 // @endcond
114114
115 Q_INVOKABLE virtual void closeScope(unity::shell::scopes::ScopeInterface* scope) = 0;
116
115Q_SIGNALS:117Q_SIGNALS:
116 // @cond118 // @cond
117 void loadedChanged();119 void loadedChanged();
118120
=== modified file 'test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScopes.cpp'
--- test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScopes.cpp 2014-10-22 16:30:55 +0000
+++ test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScopes.cpp 2015-02-12 17:18:49 +0000
@@ -92,3 +92,8 @@
92{92{
93 // Unimplemented93 // Unimplemented
94}94}
95
96void MockScopes::closeScope(unity::shell::scopes::ScopeInterface*)
97{
98 // Unimplemented
99}
95100
=== modified file 'test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScopes.h'
--- test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScopes.h 2014-10-22 15:49:26 +0000
+++ test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScopes.h 2015-02-12 17:18:49 +0000
@@ -36,6 +36,7 @@
3636
37 Q_INVOKABLE unity::shell::scopes::ScopeInterface* getScope(int row) const override;37 Q_INVOKABLE unity::shell::scopes::ScopeInterface* getScope(int row) const override;
38 Q_INVOKABLE unity::shell::scopes::ScopeInterface* getScope(const QString& scope_id) const override;38 Q_INVOKABLE unity::shell::scopes::ScopeInterface* getScope(const QString& scope_id) const override;
39 Q_INVOKABLE void closeScope(unity::shell::scopes::ScopeInterface* scope) override;
3940
40 QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override;41 QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override;
4142

Subscribers

People subscribed via source and target branches

to all changes: