Merge lp:~stolowski/unity-scopes-shell/fix-temp-scopes into lp:unity-scopes-shell
Proposed by
Andrea Cimitan
Status: | Merged |
---|---|
Approved by: | Albert Astals Cid |
Approved revision: | 196 |
Merged at revision: | 196 |
Proposed branch: | lp:~stolowski/unity-scopes-shell/fix-temp-scopes |
Merge into: | lp:unity-scopes-shell |
Diff against target: |
188 lines (+39/-20) 7 files modified
debian/control (+2/-1) src/Unity/CMakeLists.txt (+1/-1) src/Unity/scope.cpp (+6/-9) src/Unity/scope.h (+0/-2) src/Unity/scopes.cpp (+23/-6) src/Unity/scopes.h (+6/-0) tests/CMakeLists.txt (+1/-1) |
To merge this branch: | bzr merge lp:~stolowski/unity-scopes-shell/fix-temp-scopes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Albert Astals Cid (community) | Approve | ||
Michał Sawicz | Needs Fixing | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Review via email: mp+248235@code.launchpad.net |
Commit message
Keep temporary scopes list in the Scopes object instances and make Scopes the partent of temp scopes instances. Temp scopes can be closed (and freed) using closeScope() method of the original scope, or by calling closeScope() method of Scopes instance.
Description of the change
Keep temporary scopes list in the Scopes object instances and make Scopes the partent of temp scopes instances. Temp scopes can be closed (and freed) using closeScope() method of the original scope, or by calling closeScope() method of Scopes instance.
To post a comment you must log in.
FAILED: Continuous integration, rev:190 /code.launchpad .net/~stolowski /unity- scopes- shell/fix- temp-scopes/ +merge/ 248235/ +edit-commit- message
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http:// jenkins. qa.ubuntu. com/job/ unity-scopes- shell-ci/ 292/ jenkins. qa.ubuntu. com/job/ unity-scopes- shell-vivid- amd64-ci/ 34 jenkins. qa.ubuntu. com/job/ unity-scopes- shell-vivid- armhf-ci/ 34 jenkins. qa.ubuntu. com/job/ unity-scopes- shell-vivid- armhf-ci/ 34/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ unity-scopes- shell-vivid- i386-ci/ 34
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity- scopes- shell-ci/ 292/rebuild
http://