Merge lp:~stolowski/unity-2d/dash-hud-esc-handling-fix into lp:unity-2d
Proposed by
Paweł Stołowski
Status: | Merged |
---|---|
Approved by: | Albert Astals Cid |
Approved revision: | 1033 |
Merged at revision: | 1035 |
Proposed branch: | lp:~stolowski/unity-2d/dash-hud-esc-handling-fix |
Merge into: | lp:unity-2d |
Diff against target: |
143 lines (+111/-0) 3 files modified
shell/common/SearchEntry.qml (+6/-0) tests/dash/dash-tests.rb (+53/-0) tests/hud/hud_show_hide_tests.rb (+52/-0) |
To merge this branch: | bzr merge lp:~stolowski/unity-2d/dash-hud-esc-handling-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Albert Astals Cid (community) | Approve | ||
Review via email: mp+100569@code.launchpad.net |
Commit message
[dash][hud] Hitting Escape clears search query first. Hitting Escape with empty search query closes Dash/Hud. This makes Esc behavior consistent with Unity.
Description of the change
[dash][hud] Hitting Escape clears search query first. Hitting Escape with empty search query closes Dash/Hud. This makes Esc behavior consistent with Unity.
- Modified SearchEntry keyboard handling to clear input text on Escape and accept key event.
- Modified Dash and Hud keyboard handling to close the view only if search query is empty.
To post a comment you must log in.
Seems to me you don't need all the extra code in Shell.qml nor Hud.qml since you are already eating the event and it won't get propagated unless the text is already "", no?