lp:~stolowski/unity-2d/dash-hud-esc-handling-fix

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity-2d at revision 1035

Albert Astals Cid (community): Approve on 2012-04-03

Diff: 143 lines (+111/-0)

3 files modified

shell/common/SearchEntry.qml (+6/-0)
tests/dash/dash-tests.rb (+53/-0)
tests/hud/hud_show_hide_tests.rb (+52/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #966121: [dash] Esc key behavior inconsistent with Unity

Medium

Fix Released

Link a bug report

Related blueprints

1033. By Paweł Stołowski on 2012-04-03

The chnages to Shell and Hud qml are not needed since SearchEntry accepts Esc key event if search text was not empty. Removed.

1032. By Paweł Stołowski on 2012-04-03

Added testability test case for Dash.

1031. By Paweł Stołowski on 2012-04-03

Removed helper test function, simplified path to SearchEntry value.

1030. By Paweł Stołowski on 2012-04-03

Added HUD testability testcases.

1029. By Paweł Stołowski on 2012-04-02

[dash][hud] Hitting Escape clears search query first. Hitting Escape with empty search query closes Dash/Hud.
- Modified SearchEntry keyboard handling to clear input text on Escape and accept key event.
- Modified Dash and Hud keyboard handling to close the view only if search query is empty.

1028. By Paweł Stołowski on 2012-04-02

[dash] Apply search query on lens switching. Re-opening dash resets search results.

Set searchQuery property of lens model on onDashActiveLensChanged signal from shellManager.. Fixes: https://bugs.launchpad.net/bugs/947985. Approved by Albert Astals Cid.

1027. By Albert Astals Cid on 2012-04-02

Use a internal cache for the spread shown value

Otherwise when the service becomes available it may happen that we do
the shownChanged(true) because it's shown and the shownChanged(true) because of
the direct connection between signals and thus the shell ends up with
two shownChanged(true) and forces the visibiity of the launcher twice, meaning
that if we are using hide-mode 1 the launcher will be stuck shown forever
. Fixes: https://bugs.launchpad.net/bugs/940590. Approved by Pawel Stolowski.

1026. By Paweł Stołowski on 2012-03-30

[shell] Supress warnings/type error for onCountChanged property for undefined lensView.model object - check if model exists before binding to onCountChanged
  property. The warnings are:
   LensView.qml:48:5: QML Connections: Cannot assign to non-existent property "onCountChanged"
   LensView.qml:50: TypeError: Result of expression 'lensView.model' [undefined] is not an object.. Fixes: . Approved by Albert Astals Cid.

1025. By Gerry Boland on 2012-03-30

[launcher] Start the hide timer if on target animation end the mouse is not over the target. Fixes: https://bugs.launchpad.net/bugs/943296. Approved by Gerry Boland.

1024. By Paweł Stołowski on 2012-03-30

[dash] Properly handle always-fullscreen flag, forcing fullscreen mode on small screens: bind to shellManager.dashAlwaysFullScreen, not shellManager.alwaysFullscreen.. Fixes: https://bugs.launchpad.net/bugs/967305. Approved by Albert Astals Cid.