Code review comment for lp:~stewart/percona-xtrabackup/fix-ubuntu-oneiric-51-debug-build

Revision history for this message
Alexey Kopytov (akopytov) wrote :

We haven't hit this in 1.6 as there is no debug build support in 1.6.

But I'm not sure this is what we want. We patch MySQL, so we want to make sure our patches are warnings-free. So in an ideal world where there are no upstream warnings, just building with maintainer mode would be enough. In the real one, we probably want to update our patches to get rid of the upstream ones?

review: Disapprove

« Back to merge proposal