Merge lp:~stewart/percona-xtrabackup/fix-ubuntu-oneiric-51-debug-build into lp:percona-xtrabackup/1.6
Proposed by
Stewart Smith
| Status: | Rejected |
|---|---|
| Rejected by: | Alexey Kopytov |
| Proposed branch: | lp:~stewart/percona-xtrabackup/fix-ubuntu-oneiric-51-debug-build |
| Merge into: | lp:percona-xtrabackup/1.6 |
| Diff against target: |
11 lines (+1/-0) 1 file modified
utils/build.sh (+1/-0) |
| To merge this branch: | bzr merge lp:~stewart/percona-xtrabackup/fix-ubuntu-oneiric-51-debug-build |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alexey Kopytov (community) | Disapprove | ||
|
Review via email:
|
|||
Description of the change
Although we haven't hit this in 1.6 for whatever reason, we should keep it consistent between 1.6 and trunk.
To post a comment you must log in.
Unmerged revisions
- 316. By Stewart Smith
-
disable mysql maintainer mode when running configure for XB MySQL part build. This means we disable -Werror, which is probably what we want for the MySQL part anyway
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
We haven't hit this in 1.6 as there is no debug build support in 1.6.
But I'm not sure this is what we want. We patch MySQL, so we want to make sure our patches are warnings-free. So in an ideal world where there are no upstream warnings, just building with maintainer mode would be enough. In the real one, we probably want to update our patches to get rid of the upstream ones?