Merge ~steverydz/maas:hide-tag-field-if-not-editable into maas:master
Proposed by
Steve Rydz
| Status: | Merged |
|---|---|
| Approved by: | Steve Rydz |
| Approved revision: | f280390b5c181f3365e19352a09cdd0b456b80ac |
| Merge reported by: | MAAS Lander |
| Merged at revision: | not available |
| Proposed branch: | ~steverydz/maas:hide-tag-field-if-not-editable |
| Merge into: | maas:master |
| Diff against target: |
13 lines (+1/-1) 1 file modified
src/maasserver/static/partials/node-details.html (+1/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alberto Donato (community) | Approve | ||
| MAAS Lander | Approve | ||
| Anthony Dillon | Approve | ||
|
Review via email:
|
|||
Commit message
LP: #1811381 - Hide tag field if not editing
Description of the change
The tag input was showing as editable in the machine configuration view when it wasn't supposed to be. This change hides the input when not in edit mode.
QA steps:
1. Go to a machine detail view and click the 'Configuration' tab
2. See that any tags are listed but no input
3. Click the 'Edit' button for that section
4. See that the tag input is visible
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM +1