Code review comment for lp:~stevenk/launchpad/gina-populate-changelog

Revision history for this message
Graham Binns (gmb) wrote :

> 8 +Check that the changelog was uploaded to the librarian correctly:
> 9 +
> 10 + >>> print x11p.changelog.content.sha1
> 11 + 759bd2df0d886f9f06c383048afb90eaa81418f6
> 12 +

This looks like either a) sampledata or b) a magic number to me. I can't
see where it came from, and grepping isn't turning anything up. Given
that the changelog is a LibraryFileAlias I'm guessing this is buried in
test data somewhere.

Can you change this so that the sha1 is something obviously
manufactured (e.g. 4242424242424242424242424242424242424242 or
similar)? At the very least, you need to add a comment explaining where
the data comes from in the first place.

review: Needs Fixing (code)

« Back to merge proposal