Merge lp:~stevenk/launchpad/gina-populate-changelog into lp:launchpad
Proposed by
Steve Kowalik
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Graham Binns | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 11967 | ||||
Proposed branch: | lp:~stevenk/launchpad/gina-populate-changelog | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
126 lines (+37/-12) 3 files modified
lib/lp/soyuz/doc/gina.txt (+15/-0) lib/lp/soyuz/scripts/gina/handlers.py (+13/-6) lib/lp/soyuz/scripts/gina/packages.py (+9/-6) |
||||
To merge this branch: | bzr merge lp:~stevenk/launchpad/gina-populate-changelog | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+41559@code.launchpad.net |
Commit message
[r=gmb][ui=none][bug=680382] Gina now imports changelogs into the Librarian when processing new source packages.
Description of the change
This branch changes gina (the script that imports sources from Debian into LP) to also upload full changelogs to the librarian, and link the SourcePackageRe
To post a comment you must log in.
> 8 +Check that the changelog was uploaded to the librarian correctly: content. sha1 f06c383048afb90 eaa81418f6
> 9 +
> 10 + >>> print x11p.changelog.
> 11 + 759bd2df0d886f9
> 12 +
This looks like either a) sampledata or b) a magic number to me. I can't
see where it came from, and grepping isn't turning anything up. Given
that the changelog is a LibraryFileAlias I'm guessing this is buried in
test data somewhere.
Can you change this so that the sha1 is something obviously 242424242424242 4242424242 or
manufactured (e.g. 424242424242424
similar)? At the very least, you need to add a comment explaining where
the data comes from in the first place.