Code review comment for lp:~stevanr/linaro-license-protection/fallback-support

Revision history for this message
Georgy Redkozubov (gesha) wrote :

Stevan, thanks for implementing fallback, few comments below.

1) I guess these are debug prints:
73 + print path
78 + print filepath

2) Please add "*.img" to check_for_manifest_or_tarballs() function, there is galaxy nexus build that has *.img and no MANIFEST file in the same dir with 'howto':
https://snapshots.linaro.org/android/~linaro-android/galaxynexus-jb-gcc47-aosp-blob/105/target/product/maguro

3) Afaik you don't need duplicate files in templates_releases/ until they differ from the same files in templates and you want to override them.

review: Needs Fixing

« Back to merge proposal