linaro-license-protection

Merge lp:~stevanr/linaro-license-protection/fallback-support into lp:~linaro-automation/linaro-license-protection/trunk

  1. fallback-support
  2. Merge into trunk
Proposed by Stevan Radaković
Status: Merged
Approved by: Georgy Redkozubov
Approved revision: 137
Merged at revision: 136
Proposed branch: lp:~stevanr/linaro-license-protection/fallback-support
Merge into: lp:~linaro-automation/linaro-license-protection/trunk
Diff against target: 0 lines
To merge this branch: bzr merge lp:~stevanr/linaro-license-protection/fallback-support
Reviewer Review Type Date Requested Status
Georgy Redkozubov Approve
Review via email: mp+130527@code.launchpad.net

Description of the change

Implement fallback support for howto files for textile rendering.

To post a comment you must log in.
Revision history for this message
Georgy Redkozubov (gesha) wrote :

Stevan, thanks for implementing fallback, few comments below.

1) I guess these are debug prints:
73 + print path
78 + print filepath

2) Please add "*.img" to check_for_manifest_or_tarballs() function, there is galaxy nexus build that has *.img and no MANIFEST file in the same dir with 'howto':
https://snapshots.linaro.org/android/~linaro-android/galaxynexus-jb-gcc47-aosp-blob/105/target/product/maguro

3) Afaik you don't need duplicate files in templates_releases/ until they differ from the same files in templates and you want to override them.

review: Needs Fixing
lp:~stevanr/linaro-license-protection/fallback-support updated
137. By Stevan Radaković

Fixes from code review.

Revision history for this message
Georgy Redkozubov (gesha) wrote :

Looks good

review: Approve
lp:~stevanr/linaro-license-protection/fallback-support updated
138. By Stevan Radaković

Last minute CSS changes.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches