Code review comment for lp:~stefan.goetz-deactivatedaccount/hipl/msg-bfr
Revision history for this message
| Stefan Götz (stefan.goetz-deactivatedaccount) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Hi Miika!
> Another small comment. This was removed from the R1 deallocation procedure:
>
> 43 - hip_r1table = NULL;
>
> While this is strictly speaking not necessary, I have found it easier to debug
> NULL pointer crashes rather than pointers that are freed.
True. Given that hip_r1table is a local variable and that it is no longer allocated dynamically, it does not apply in this case.
Unless there is anything else, would you give me an 'approve' on the merge proposal?
Stefan