Code review comment for lp:~stefan.goetz-deactivatedaccount/hipl/msg-bfr

Revision history for this message
Christof Mroz (christof-mroz) wrote :

If it works, I'm fine with it apart from one minor thing:

> === modified file 'hipd/output.c'
> --- hipd/output.c 2011-05-02 14:19:14 +0000
> +++ hipd/output.c 2011-05-07 06:46:29 +0000
> @@ -568,6 +568,8 @@
> /**
> * Construct a new R1 packet payload
> *
> + * @param msg points to a message object backed by HIP_MAX_PACKET bytes
> + * of memory to which the R1 message is written.
> * @param src_hit a pointer to the source host identity tag used in the
> * packet.
> * @param sign a funtion pointer to a signature funtion.
> @@ -576,19 +578,20 @@
>
> * @param cookie_k the difficulty value for the puzzle
> * @return a pointer to the payload on success, NULL on error.
> */

You modified the function to return -1 rather than NULL.

review: Needs Fixing

« Back to merge proposal