Merge lp:~ssalley/ubuntu/natty/likewise-open/likewise-open-fix-684579 into lp:ubuntu/natty/likewise-open

Proposed by Scott Salley
Status: Needs review
Proposed branch: lp:~ssalley/ubuntu/natty/likewise-open/likewise-open-fix-684579
Merge into: lp:ubuntu/natty/likewise-open
Diff against target: 106 lines (+74/-1)
4 files modified
debian/changelog (+11/-0)
debian/patches/add-dependencies-1.diff (+55/-0)
debian/patches/series (+1/-0)
debian/rules (+7/-1)
To merge this branch: bzr merge lp:~ssalley/ubuntu/natty/likewise-open/likewise-open-fix-684579
Reviewer Review Type Date Requested Status
Chuck Short Pending
Review via email: mp+47335@code.launchpad.net

Description of the change

The changes in the build environment have exposed places where libraries required for proper operation are missing from the link. This set of changes corrects the known problems for missing libraries (via patches) and also allows for autoreconf to be run during the build process to properly integrate those patches.

Note that many of these changes are being integrated or have been integrated upstream, but that they are generally being discovered in Natty.

To post a comment you must log in.

Unmerged revisions

20. By Scott Salley

* LP: #684579
  - added debian/patches/add-dependencies-1.diff to add in libraries missing
    from the link that affect runtime behavior and prevent building when
    autotools are re-run
  - modified debian/rules to regenerate autoconf files so Makefile.am changes
    are picked up and to make future patch work easier

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-11-22 12:06:00 +0000
+++ debian/changelog 2011-01-25 00:12:17 +0000
@@ -1,3 +1,14 @@
1likewise-open (6.0.0.53010-2) natty; urgency=low
2
3 * LP: #684579
4 - added debian/patches/add-dependencies-1.diff to add in libraries missing
5 from the link that affect runtime behavior and prevent building when
6 autotools are re-run
7 - modified debian/rules to regenerate autoconf files so Makefile.am changes
8 are picked up and to make future patch work easier
9
10 -- Scott Salley <ssalley@ssalley-ubuntu.corp.centeris.com> Mon, 24 Jan 2011 15:03:26 -0800
11
1likewise-open (6.0.0.53010-1) natty; urgency=high12likewise-open (6.0.0.53010-1) natty; urgency=high
213
3 * Likewise Open 6.014 * Likewise Open 6.0
415
=== added file 'debian/patches/add-dependencies-1.diff'
--- debian/patches/add-dependencies-1.diff 1970-01-01 00:00:00 +0000
+++ debian/patches/add-dependencies-1.diff 2011-01-25 00:12:17 +0000
@@ -0,0 +1,55 @@
1diff -Nurb -x debian likewise-open-6.0.0.53010/lsass/configure.in likewise-open-6.0.0.53010/lsass/configure.in
2--- likewise-open-6.0.0.53010/lsass/configure.in 2010-10-19 14:03:01.000000000 -0700
3+++ likewise-open-6.0.0.53010/lsass/configure.in 2011-01-23 00:16:40.000000000 -0800
4@@ -882,15 +882,6 @@
5 # include <wc16str.h>
6 #endif
7 ])
8-AC_CHECK_MEMBERS([ucontext_t.uc_mcontext,
9- ucontext_t.uc_mcontext->__ss,
10- ucontext_t.uc_mcontext->__ss.__rip,
11- ucontext_t.uc_mcontext->__ss.__eip],
12-[], [], [AC_INCLUDES_DEFAULT
13-#ifdef HAVE_EXECINFO_H
14-# include <execinfo.h>
15-#endif
16-])
17
18 if test x"$ENABLE_COMPAT" = x"false"; then
19 AC_CHECK_HEADER([reg/reg.h],,[AC_MSG_ERROR([Could not find lwreg headers])],
20diff -Nurb -x debian likewise-open-6.0.0.53010/lwdns/lwdns/Makefile.am likewise-open-6.0.0.53010/lwdns/lwdns/Makefile.am
21--- likewise-open-6.0.0.53010/lwdns/lwdns/Makefile.am 2010-10-19 13:54:29.000000000 -0700
22+++ likewise-open-6.0.0.53010/lwdns/lwdns/Makefile.am 2011-01-23 00:45:20.000000000 -0800
23@@ -34,7 +34,8 @@
24 @SOCKET_LIBS@ \
25 @NSL_LIBS@ \
26 @PTHREAD_LIBS@ \
27- $(LWBASE_LIBS)
28+ $(LWBASE_LIBS) \
29+ $(LWBASE_NOTHR_LIBS)
30
31 liblwdns_la_LDFLAGS = \
32 @KRB5_LDFLAGS@ \
33diff -Nurb -x debian likewise-open-6.0.0.53010/lwreg/client/Makefile.am likewise-open-6.0.0.53010/lwreg/client/Makefile.am
34--- likewise-open-6.0.0.53010/lwreg/client/Makefile.am 2010-10-19 13:54:30.000000000 -0700
35+++ likewise-open-6.0.0.53010/lwreg/client/Makefile.am 2011-01-22 23:55:41.000000000 -0800
36@@ -11,4 +11,6 @@
37 @LWMSG_INCLUDES@
38
39 libregclient_la_LIBADD = \
40- @top_builddir@/common/libregcommon.la
41+ @top_builddir@/common/libregcommon.la \
42+ @LWBASE_LIBS@ \
43+ @LWMSG_LIBS@
44diff -Nurb -x debian likewise-open-6.0.0.53010/netlogon/tools/set_log_level/Makefile.am likewise-open-6.0.0.53010/netlogon/tools/set_log_level/Makefile.am
45--- likewise-open-6.0.0.53010/netlogon/tools/set_log_level/Makefile.am 2010-11-22 11:55:16.000000000 -0800
46+++ likewise-open-6.0.0.53010/netlogon/tools/set_log_level/Makefile.am 2011-01-23 00:43:51.000000000 -0800
47@@ -5,7 +5,7 @@
48 lwnet_set_log_level_LDADD = \
49 @top_builddir@/client/liblwnetclientapi.la \
50 @top_builddir@/common/liblwnetcommon.la \
51- -llwadvapi
52+ -llwadvapi -llwadvapi_nothr
53
54 lwnet_set_log_level_SOURCES = \
55 main.c
056
=== modified file 'debian/patches/series'
--- debian/patches/series 2010-11-22 12:06:00 +0000
+++ debian/patches/series 2011-01-25 00:12:17 +0000
@@ -16,3 +16,4 @@
16datadir.diff16datadir.diff
17eventlog-libxml217eventlog-libxml2
18use_offsetof.diff18use_offsetof.diff
19add-dependencies-1.diff
1920
=== modified file 'debian/rules'
--- debian/rules 2010-11-22 12:06:00 +0000
+++ debian/rules 2011-01-25 00:12:17 +0000
@@ -45,7 +45,13 @@
45configure: configure-stamp45configure: configure-stamp
46configure-stamp: $(QUILT_STAMPFN)46configure-stamp: $(QUILT_STAMPFN)
47 dh_testdir47 dh_testdir
48 ## Everything is done during the build phase48 for f in lwbase lwmsg \
49 lwreg pstore lwadvapi centutils netlogon lwio lwsm libschannel \
50 dcerpc eventlog lsass lwdns \
51 domainjoin srvsvc lwnetapi lwtools lwupgrade; do \
52 echo $$f && (cd $$f && ./autogen.sh) || exit 1;\
53 done
54 find . -type d -name autom4te.cache | xargs /bin/rm -rf
49 touch configure-stamp55 touch configure-stamp
5056
51build: build-stamp57build: build-stamp

Subscribers

People subscribed via source and target branches

to all changes: