Merge lp:~ssalley/ubuntu/natty/likewise-open/likewise-open-fix-684579 into lp:ubuntu/natty/likewise-open

Proposed by Scott Salley
Status: Needs review
Proposed branch: lp:~ssalley/ubuntu/natty/likewise-open/likewise-open-fix-684579
Merge into: lp:ubuntu/natty/likewise-open
Diff against target: 106 lines (+74/-1)
4 files modified
debian/changelog (+11/-0)
debian/patches/add-dependencies-1.diff (+55/-0)
debian/patches/series (+1/-0)
debian/rules (+7/-1)
To merge this branch: bzr merge lp:~ssalley/ubuntu/natty/likewise-open/likewise-open-fix-684579
Reviewer Review Type Date Requested Status
Chuck Short Pending
Review via email: mp+47335@code.launchpad.net

Description of the change

The changes in the build environment have exposed places where libraries required for proper operation are missing from the link. This set of changes corrects the known problems for missing libraries (via patches) and also allows for autoreconf to be run during the build process to properly integrate those patches.

Note that many of these changes are being integrated or have been integrated upstream, but that they are generally being discovered in Natty.

To post a comment you must log in.

Unmerged revisions

20. By Scott Salley

* LP: #684579
  - added debian/patches/add-dependencies-1.diff to add in libraries missing
    from the link that affect runtime behavior and prevent building when
    autotools are re-run
  - modified debian/rules to regenerate autoconf files so Makefile.am changes
    are picked up and to make future patch work easier

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-11-22 12:06:00 +0000
3+++ debian/changelog 2011-01-25 00:12:17 +0000
4@@ -1,3 +1,14 @@
5+likewise-open (6.0.0.53010-2) natty; urgency=low
6+
7+ * LP: #684579
8+ - added debian/patches/add-dependencies-1.diff to add in libraries missing
9+ from the link that affect runtime behavior and prevent building when
10+ autotools are re-run
11+ - modified debian/rules to regenerate autoconf files so Makefile.am changes
12+ are picked up and to make future patch work easier
13+
14+ -- Scott Salley <ssalley@ssalley-ubuntu.corp.centeris.com> Mon, 24 Jan 2011 15:03:26 -0800
15+
16 likewise-open (6.0.0.53010-1) natty; urgency=high
17
18 * Likewise Open 6.0
19
20=== added file 'debian/patches/add-dependencies-1.diff'
21--- debian/patches/add-dependencies-1.diff 1970-01-01 00:00:00 +0000
22+++ debian/patches/add-dependencies-1.diff 2011-01-25 00:12:17 +0000
23@@ -0,0 +1,55 @@
24+diff -Nurb -x debian likewise-open-6.0.0.53010/lsass/configure.in likewise-open-6.0.0.53010/lsass/configure.in
25+--- likewise-open-6.0.0.53010/lsass/configure.in 2010-10-19 14:03:01.000000000 -0700
26++++ likewise-open-6.0.0.53010/lsass/configure.in 2011-01-23 00:16:40.000000000 -0800
27+@@ -882,15 +882,6 @@
28+ # include <wc16str.h>
29+ #endif
30+ ])
31+-AC_CHECK_MEMBERS([ucontext_t.uc_mcontext,
32+- ucontext_t.uc_mcontext->__ss,
33+- ucontext_t.uc_mcontext->__ss.__rip,
34+- ucontext_t.uc_mcontext->__ss.__eip],
35+-[], [], [AC_INCLUDES_DEFAULT
36+-#ifdef HAVE_EXECINFO_H
37+-# include <execinfo.h>
38+-#endif
39+-])
40+
41+ if test x"$ENABLE_COMPAT" = x"false"; then
42+ AC_CHECK_HEADER([reg/reg.h],,[AC_MSG_ERROR([Could not find lwreg headers])],
43+diff -Nurb -x debian likewise-open-6.0.0.53010/lwdns/lwdns/Makefile.am likewise-open-6.0.0.53010/lwdns/lwdns/Makefile.am
44+--- likewise-open-6.0.0.53010/lwdns/lwdns/Makefile.am 2010-10-19 13:54:29.000000000 -0700
45++++ likewise-open-6.0.0.53010/lwdns/lwdns/Makefile.am 2011-01-23 00:45:20.000000000 -0800
46+@@ -34,7 +34,8 @@
47+ @SOCKET_LIBS@ \
48+ @NSL_LIBS@ \
49+ @PTHREAD_LIBS@ \
50+- $(LWBASE_LIBS)
51++ $(LWBASE_LIBS) \
52++ $(LWBASE_NOTHR_LIBS)
53+
54+ liblwdns_la_LDFLAGS = \
55+ @KRB5_LDFLAGS@ \
56+diff -Nurb -x debian likewise-open-6.0.0.53010/lwreg/client/Makefile.am likewise-open-6.0.0.53010/lwreg/client/Makefile.am
57+--- likewise-open-6.0.0.53010/lwreg/client/Makefile.am 2010-10-19 13:54:30.000000000 -0700
58++++ likewise-open-6.0.0.53010/lwreg/client/Makefile.am 2011-01-22 23:55:41.000000000 -0800
59+@@ -11,4 +11,6 @@
60+ @LWMSG_INCLUDES@
61+
62+ libregclient_la_LIBADD = \
63+- @top_builddir@/common/libregcommon.la
64++ @top_builddir@/common/libregcommon.la \
65++ @LWBASE_LIBS@ \
66++ @LWMSG_LIBS@
67+diff -Nurb -x debian likewise-open-6.0.0.53010/netlogon/tools/set_log_level/Makefile.am likewise-open-6.0.0.53010/netlogon/tools/set_log_level/Makefile.am
68+--- likewise-open-6.0.0.53010/netlogon/tools/set_log_level/Makefile.am 2010-11-22 11:55:16.000000000 -0800
69++++ likewise-open-6.0.0.53010/netlogon/tools/set_log_level/Makefile.am 2011-01-23 00:43:51.000000000 -0800
70+@@ -5,7 +5,7 @@
71+ lwnet_set_log_level_LDADD = \
72+ @top_builddir@/client/liblwnetclientapi.la \
73+ @top_builddir@/common/liblwnetcommon.la \
74+- -llwadvapi
75++ -llwadvapi -llwadvapi_nothr
76+
77+ lwnet_set_log_level_SOURCES = \
78+ main.c
79
80=== modified file 'debian/patches/series'
81--- debian/patches/series 2010-11-22 12:06:00 +0000
82+++ debian/patches/series 2011-01-25 00:12:17 +0000
83@@ -16,3 +16,4 @@
84 datadir.diff
85 eventlog-libxml2
86 use_offsetof.diff
87+add-dependencies-1.diff
88
89=== modified file 'debian/rules'
90--- debian/rules 2010-11-22 12:06:00 +0000
91+++ debian/rules 2011-01-25 00:12:17 +0000
92@@ -45,7 +45,13 @@
93 configure: configure-stamp
94 configure-stamp: $(QUILT_STAMPFN)
95 dh_testdir
96- ## Everything is done during the build phase
97+ for f in lwbase lwmsg \
98+ lwreg pstore lwadvapi centutils netlogon lwio lwsm libschannel \
99+ dcerpc eventlog lsass lwdns \
100+ domainjoin srvsvc lwnetapi lwtools lwupgrade; do \
101+ echo $$f && (cd $$f && ./autogen.sh) || exit 1;\
102+ done
103+ find . -type d -name autom4te.cache | xargs /bin/rm -rf
104 touch configure-stamp
105
106 build: build-stamp

Subscribers

People subscribed via source and target branches

to all changes: