Merge lp:~speakman/ubuntu/natty/padevchooser/drop-use_stock_gnome_icons.patch into lp:ubuntu/natty/padevchooser

Proposed by Daniel Nyström
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp:~speakman/ubuntu/natty/padevchooser/drop-use_stock_gnome_icons.patch
Merge into: lp:ubuntu/natty/padevchooser
Diff against target: 117 lines (+6/-90)
3 files modified
debian/changelog (+6/-0)
debian/patches/series (+0/-1)
debian/patches/use_stock_gnome_icons.patch (+0/-89)
To merge this branch: bzr merge lp:~speakman/ubuntu/natty/padevchooser/drop-use_stock_gnome_icons.patch
Reviewer Review Type Date Requested Status
Martin Pitt Disapprove
Review via email: mp+59425@code.launchpad.net

Description of the change

Get icons back to padevchooser. Although they doesn't match Ubuntu default theme, there are at least some.

(Sorry for re-requesting - wrong commit email in previous version)

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Closing, see bug report. Thanks!

review: Disapprove

Unmerged revisions

8. By Daniel Nyström

Drop use_stock_gnome_icons.patch. Fixes (LP: #632468)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2009-04-16 18:36:50 +0000
+++ debian/changelog 2011-04-28 20:59:53 +0000
@@ -1,3 +1,9 @@
1padevchooser (0.9.3-2ubuntu5) natty; urgency=low
2
3 * Drop use_stock_gnome_icons.patch. Fixes (LP: #632468)
4
5 -- Daniel Nyström <daniel@nystrom.st> Thu, 28 Apr 2011 22:22:05 +0200
6
1padevchooser (0.9.3-2ubuntu4) jaunty; urgency=low7padevchooser (0.9.3-2ubuntu4) jaunty; urgency=low
28
3 * lp147305.patch: Don't crash when zeroconf devices disappear9 * lp147305.patch: Don't crash when zeroconf devices disappear
410
=== modified file 'debian/patches/series'
--- debian/patches/series 2009-04-16 18:36:50 +0000
+++ debian/patches/series 2011-04-28 20:59:53 +0000
@@ -1,5 +1,4 @@
1# This series applies on GIT commit 42cd6a27e16cacb8b33efd4105497c864ce4e8ff1# This series applies on GIT commit 42cd6a27e16cacb8b33efd4105497c864ce4e8ff
2statustray_svn24.patch2statustray_svn24.patch
3use_stock_gnome_icons.patch
4desktop_hig_comment.patch3desktop_hig_comment.patch
5lp147305.patch4lp147305.patch
65
=== removed file 'debian/patches/use_stock_gnome_icons.patch'
--- debian/patches/use_stock_gnome_icons.patch 2008-03-21 14:31:04 +0000
+++ debian/patches/use_stock_gnome_icons.patch 1970-01-01 00:00:00 +0000
@@ -1,89 +0,0 @@
1Use stock Gnome icons (instead of Tango icons)
2
3From: CJ van den Berg <cj@vdbonline.com>
4
5
6---
7
8 src/padevchooser.c | 14 +++++++-------
9 src/padevchooser.desktop | 2 +-
10 src/padevchooser.glade | 2 +-
11 3 files changed, 9 insertions(+), 9 deletions(-)
12
13Index: padevchooser-0.9.3/src/padevchooser.c
14===================================================================
15--- padevchooser-0.9.3.orig/src/padevchooser.c 2008-03-21 15:13:46.000000000 -0500
16+++ padevchooser-0.9.3/src/padevchooser.c 2008-03-21 15:14:49.000000000 -0500
17@@ -162,13 +162,13 @@
18
19 if (!notification) {
20 s = g_strdup_printf("<i>%s</i>\n%s", title, text);
21- notification = notify_notification_new(title, s, "audio-card", GTK_WIDGET(tray_icon));
22+ notification = notify_notification_new(title, s, "stock_line_in", GTK_WIDGET(tray_icon));
23 notify_notification_set_category(notification, "device.added");
24 notify_notification_set_urgency(notification, NOTIFY_URGENCY_LOW);
25 g_signal_connect_swapped(G_OBJECT(notification), "closed", G_CALLBACK(notification_closed), NULL);
26 } else {
27 s = g_strdup_printf("%s\n\n<i>%s</i>\n%s", last_events, title, text);
28- notify_notification_update(notification, title, s, "audio-card");
29+ notify_notification_update(notification, title, s, "stock_line_in");
30 }
31
32 g_free(last_events);
33@@ -525,7 +525,7 @@
34 tray_icon = gtk_status_icon_new();
35
36 g_signal_connect_object(G_OBJECT(tray_icon), "activate", G_CALLBACK(tray_icon_on_click), tray_icon, 0);
37- gtk_status_icon_set_from_icon_name(tray_icon, "audio-card");
38+ gtk_status_icon_set_from_icon_name(tray_icon, "stock_line_in");
39 gtk_status_icon_set_tooltip(tray_icon, "PulseAudio Applet");
40 gtk_status_icon_set_visible(tray_icon, TRUE);
41
42@@ -583,9 +583,9 @@
43 append_default_device_menu_items(source_submenu, &no_sources_menu_item, &default_source_menu_item, &other_source_menu_item, source_default_cb, source_other_cb);
44 append_default_device_menu_items(server_submenu, &no_servers_menu_item, &default_server_menu_item, &other_server_menu_item, server_default_cb, server_other_cb);
45
46- append_submenu(menu, "Default S_erver", server_submenu, "network-wired");
47- append_submenu(menu, "Default S_ink", sink_submenu, "audio-card");
48- append_submenu(menu, "Default S_ource", source_submenu, "audio-input-microphone");
49+ append_submenu(menu, "Default S_erver", server_submenu, "gnome-dev-ethernet");
50+ append_submenu(menu, "Default S_ink", sink_submenu, "stock_headphones");
51+ append_submenu(menu, "Default S_ource", source_submenu, "stock_mic");
52 gtk_menu_shell_append(GTK_MENU_SHELL(menu), gtk_separator_menu_item_new());
53
54 item = append_menuitem(menu, "_Manager...", NULL);
55@@ -593,7 +593,7 @@
56 g_free(c);
57 g_signal_connect(G_OBJECT(item), "activate", G_CALLBACK(start_manager_cb), NULL);
58
59- item = append_menuitem(menu, "_Volume Control...", "multimedia-volume-control");
60+ item = append_menuitem(menu, "_Volume Control...", "stock_volume");
61 gtk_widget_set_sensitive(item, !!(c = g_find_program_in_path("pavucontrol")));
62 g_free(c);
63 g_signal_connect(G_OBJECT(item), "activate", G_CALLBACK(start_vucontrol_cb), NULL);
64Index: padevchooser-0.9.3/src/padevchooser.desktop
65===================================================================
66--- padevchooser-0.9.3.orig/src/padevchooser.desktop 2008-03-21 15:12:36.000000000 -0500
67+++ padevchooser-0.9.3/src/padevchooser.desktop 2008-03-21 15:13:48.000000000 -0500
68@@ -5,7 +5,7 @@
69 GenericName=Device Chooser
70 Comment=An Applet for Quick Device Changing
71 Exec=padevchooser
72-Icon=audio-card
73+Icon=stock_line_in
74 StartupNotify=true
75 Type=Application
76 Categories=Application;AudioVideo;Audio;
77Index: padevchooser-0.9.3/src/padevchooser.glade
78===================================================================
79--- padevchooser-0.9.3.orig/src/padevchooser.glade 2008-03-21 15:12:36.000000000 -0500
80+++ padevchooser-0.9.3/src/padevchooser.glade 2008-03-21 15:13:48.000000000 -0500
81@@ -76,7 +76,7 @@
82 <widget class="GtkImage" id="image1">
83 <property name="visible">True</property>
84 <property name="icon_size">6</property>
85- <property name="icon_name">audio-card</property>
86+ <property name="icon_name">stock_sound</property>
87 <property name="xalign">0.5</property>
88 <property name="yalign">0.5</property>
89 <property name="xpad">0</property>

Subscribers

People subscribed via source and target branches