Code review comment for lp:~spacedout/qtubuntu/fix_opengl_sharing

Revision history for this message
David Fries (spacedout) wrote :

On Tue, May 21, 2013 at 05:10:37PM -0000, Loïc Molinari wrote:
> The code looks good. I'll test on the device and approve if everything's fine.

Depending on how you plan to test it I wanted to pass along a tip.

There is a related issue I'll mention that I've only worked around.
The problem is while I could create a new window for the new context,
it would be resized to the full screen, even though show() was never
called. While the hidden window was not visible (the main window
continued to be updated and displayed), all touch events were directed
to the hidden window. My hack was to turn around and deliver them in
my code to the main window object so things would continue to work.

The upcoming Qt 5.1 has an QOffscreenSurface that would be nice to
support directly, but that's independent of this.

--
David Fries <email address hidden> PGP pub CB1EE8F0
http://fries.net/~david/

« Back to merge proposal