Merge lp:~spacedout/qtubuntu/fix_opengl_sharing into lp:qtubuntu
Status: | Work in progress |
---|---|
Proposed branch: | lp:~spacedout/qtubuntu/fix_opengl_sharing |
Merge into: | lp:qtubuntu |
Diff against target: |
101 lines (+23/-13) 4 files modified
src/platforms/base/context.cc (+18/-4) src/platforms/base/context.h (+3/-1) src/platforms/base/integration.cc (+2/-7) src/platforms/base/integration.h (+0/-1) |
To merge this branch: | bzr merge lp:~spacedout/qtubuntu/fix_opengl_sharing |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gerry Boland (community) | Needs Fixing | ||
Loïc Molinari | Pending | ||
Francis Ginther | why hasn't jenkins reviewed this yet? | Pending | |
PS Jenkins bot | continuous-integration | Pending | |
Review via email: mp+163466@code.launchpad.net |
Commit message
All of OpenGL, OpenGLES, and Qt5 support sharing a context, but the ubuntu-touch Qt5 abstraction does not, this adds that support, otherwise programs can't offload tasks to another thread to execute.
Description of the change
All of OpenGL, OpenGLES, and Qt5 support sharing a context, but the ubuntu-touch Qt5 abstraction does not, this adds that support, otherwise programs can't offload tasks to another thread to execute.
Unmerged revisions
- 132. By David Fries
-
Enable sharing OpenGL contexts
Sharing OpenGL contexts are required to offload OpenGL tasks to another
thread such as uploading textues or drawing into a framebuffer to use
as a texture. - 131. By David Fries
-
QUbuntuBaseInte
gration allocate in const remove typecast The base QPlatformIntegr
ation doesn't have the non-const version of
createPlatformOpenGLContext and this routine doesn't require it,
so simplifying the code and removing a typecast along the way.
Jenkins will not perform a ci build on this until it is reviewed and top approved by a Canonical employee. Your best bet for finding a reviewer is through the #ubuntu-touch IRC channel on freenode.
If this is approved and still fails to be tested by jenkins, please ping me again.