Code review comment for lp:~soren/nova/libvirt-is-more-than-kvm-and-qemu
Revision history for this message
| Soren Hansen (soren) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> Looks good. The one comment I have is probably not even your code :)
No, it's not :)
> Line 63: if list(set(tkeys)) != list(set(keys)):
>
> Is the list() call needed? "if set(tkeys) != set(keys):" still works I think,
> and might be more clear.
..and more correct. When list()ifying the set()s, they might end up in different orders and hence fail the comparison. I'll fix this in a different patch.