lp:~soren/nova/libvirt-is-more-than-kvm-and-qemu
- Get this branch:
- bzr branch lp:~soren/nova/libvirt-is-more-than-kvm-and-qemu
Branch merges
- Paul Voccio (community): Approve
- Christian Berendt (community): Approve
- Rick Harris (community): Approve
- Brian Lamar (community): Approve
-
Diff: 72 lines (+31/-18)2 files modifiedbin/nova-manage (+4/-2)
nova/virt/libvirt_conn.py (+27/-16)
Related source package recipes
Related bugs
Related blueprints
Branch information
Recent revisions
- 810. By Soren Hansen
-
Just use 'if foo' instead of 'if len(foo)'. It will fail as spectacularly if its not acting on a sequence anyways.
- 807. By Brian Lamar
-
Fixed lp732866 by catching relevant `exception.
NotFound` exception. Tests did not uncover this vulnerability due to "incorrect" FakeAuthManager. I say "incorrect" because potentially different implementations (LDAP or Database driven) of AuthManager might return different errors from `get_user_ from_access_ key`. Also, removed all references to 'bacon', 'ham', 'herp', and 'derp' and replaced them with hopefully more helpful terms.
Long story short it addresses the immediate issue while throughly ignoring the larger issue, which is correctly testing all implementations of Auth. I find this acceptable as currently the future of auth is in flux.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:~hudson-openstack/nova/trunk
