Code review comment for lp:~soren/nova/libvirt-is-more-than-kvm-and-qemu

Revision history for this message
Brian Lamar (blamar) wrote :

Looks good. The one comment I have is probably not even your code :)

Line 63: if list(set(tkeys)) != list(set(keys)):

Is the list() call needed? "if set(tkeys) != set(keys):" still works I think, and might be more clear.

review: Approve

« Back to merge proposal