Code review comment for ~solazio/canonical-identity-provider:fix-truncated-columns

Revision history for this message
Maximiliano Bertacchini (maxiberta) wrote :

Thanks! Columns are not truncated now, which certainly fixes the issue with copying its contents.

Otoh, row height is now ~8x taller, which might make the table unwieldily long, imho. Would that be an issue?

  https://private-fileshare.canonical.com/~maxiberta/Screenshot_20200625_120258.png

If so, maybe it can be improved a bit:

- Join Type and IP address columns.
- Make the UA column wider.
- Move general layout from 4+8 cols to 3+9 cols (this is a site-wide design change and would probably need a more thorough review from UX/Design).

  https://private-fileshare.canonical.com/~maxiberta/Screenshot_20200625_120547.png

Diff (including mock data): https://pastebin.canonical.com/p/qcM7HYs3Vj/

This is just a mock I came up with in 5mins. Please feel free to ignore :)

review: Approve

« Back to merge proposal