Merge ~solazio/canonical-identity-provider:fix-truncated-columns into canonical-identity-provider:master

[Ovidiu Suciu]

Fix the truncated text on the account activity page

Fix the truncated text on the account activity page.

This is a fix for https://bugs.launchpad.net/canonical-identity-provider/+bug/1863218

[Maximiliano Bertacchini (maxiberta)]

Thanks! Columns are not truncated now, which certainly fixes the issue with copying its contents.

Otoh, row height is now ~8x taller, which might make the table unwieldily long, imho. Would that be an issue?

  https://private-fileshare.canonical.com/~maxiberta/Screenshot_20200625_120258.png

If so, maybe it can be improved a bit:

- Join Type and IP address columns.
- Make the UA column wider.
- Move general layout from 4+8 cols to 3+9 cols (this is a site-wide design change and would probably need a more thorough review from UX/Design).

  https://private-fileshare.canonical.com/~maxiberta/Screenshot_20200625_120547.png

Diff (including mock data): https://pastebin.canonical.com/p/qcM7HYs3Vj/

This is just a mock I came up with in 5mins. Please feel free to ignore :)

review: Approve

[Maximiliano Bertacchini (maxiberta)]

Date/time can also be split trivially: https://pastebin.canonical.com/p/mQkX6PgcMp/

[Ovidiu Suciu (solazio)]

Thanks for the comments. Let me run this through UX & Design first and then I'll do the updates.

[Maximiliano Bertacchini (maxiberta)]

Looks great, thanks!

review: Approve

[Otto Co-Pilot (otto-copilot)]

A commit message must be set
https://jenkins.ols.canonical.com/online-services/job/canonical-identity-provider/353/

[Otto Co-Pilot (otto-copilot)]

Running landing tests failed
https://jenkins.ols.canonical.com/online-services/job/canonical-identity-provider/354/

36dabb0... by Ovidiu Suciu on 2020-07-01

Fix failing AuthLogTestCase test

[Maximiliano Bertacchini (maxiberta)]

+1

review: Approve

diff --git a/src/webui/templates/account/auth_log.html b/src/webui/templates/account/auth_log.html
index 55def28..83b844c 100644
--- a/src/webui/templates/account/auth_log.html
+++ b/src/webui/templates/account/auth_log.html
@@ -30,19 +30,17 @@ GNU Affero General Public License version 3 (see the file LICENSE).
   <table class="p-table">
     <thead>
       <tr>
-        <th>{% trans "Time/date" %}</th>
-        <th>{% trans "Type" %}</th>
-        <th>{% trans "IP address" %}</th>
-        <th>{% trans "User Agent/Browser" %}</th>
+        <th>{% trans "date<br />time" %}</th>
+        <th>{% trans "Type<br />IP address" %}</th>
+        <th style="width: 50%">{% trans "User Agent (Browser)" %}</th>
       </tr>
     </thead>
     <tbody>
       {% for attempt in auth_log %}
       <tr>
-        <td class="p-table__item--truncate" title="{{ attempt.when_created }}">{{ attempt.when_created }}</td>
-        <td>{{ attempt.log_type_label }}</td>
-        <td>{{ attempt.remote_ip }}</td>
-        <td class="p-table__item--truncate" title="{{ attempt.user_agent }}">{{ attempt.user_agent }}</td>
+        <td>{{ attempt.when_created|date }}<br />{{ attempt.when_created|time }}</td>
+        <td>{{ attempt.log_type_label }}<br />{{ attempt.remote_ip }}</td>
+        <td>{{ attempt.user_agent }}</td>
       </tr>
       {% endfor %}
     </tbody>
diff --git a/src/webui/templates/vanilla/base.html b/src/webui/templates/vanilla/base.html
index 7d1f356..7f8cd4d 100644
--- a/src/webui/templates/vanilla/base.html
+++ b/src/webui/templates/vanilla/base.html
@@ -53,12 +53,12 @@ class="{% block bodyclass %}{% if user.is_authenticated %}with-menu{% endif %}{%
       <div id="{% block content_id %}box{% endblock %}" class="row">
         {% block menu %}
         {% if user.is_authenticated %}
-        <div class="col-4 p-sidebar">
+        <div class="col-3 p-sidebar">
           {% include "vanilla/widgets/personal-menu.html" %}
         </div>
         {% endif %}
         {% endblock %}
-        <div class="{% block content_class %}col-8{% endblock %}">
+        <div class="{% block content_class %}col-9{% endblock %}">
           <section class="p-strip">
             {% block readonly %}
             {% if readonly %}
diff --git a/src/webui/tests/test_views_auth_log.py b/src/webui/tests/test_views_auth_log.py
index 75c5f18..fb14f92 100644
--- a/src/webui/tests/test_views_auth_log.py
+++ b/src/webui/tests/test_views_auth_log.py
@@ -28,7 +28,7 @@ class AuthLogTestCase(AuthenticatedTestCase):
         r = self.client.get(reverse('auth_log'))
         assert len(r.context['auth_log']) != 0
         self.assertTemplateUsed(r, 'account/auth_log.html')
-        self.assertContains(r, "Time/date")
+        self.assertContains(r, "date<br />time")
         self.assertContains(r, "Recent accesses")
 
     def test_auth_log_page_limit_per_page_auth_records(self):