Code review comment for lp:~smspillaz/compiz-core/compiz-core.fix_931927

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Conditionally approved, pending the 1-line fix Tim mentioned:
210 + static CompOption::Vector v (0);
becomes:
210 + static CompOption::Vector v;

I've also tested for further API breakage in libcompizconfig, compiz-plugins-main and compiz-plugins-extra. Only main (expo) failed, which Sam has already proposed a fix for.

review: Approve

« Back to merge proposal