lp:~smspillaz/compiz-core/compiz-core.fix_931927
- Get this branch:
- bzr branch lp:~smspillaz/compiz-core/compiz-core.fix_931927
Branch merges
- Alan Griffiths: Approve
- Daniel van Vugt: Approve
- Tim Penhey: Pending requested
-
Diff: 420 lines (+87/-89)9 files modifiedinclude/core/abiversion.h (+1/-1)
include/core/option.h (+3/-3)
include/core/plugin.h (+2/-2)
plugins/move/src/move.cpp (+7/-7)
plugins/resize/src/resize.cpp (+7/-7)
src/event.cpp (+1/-1)
src/option.cpp (+62/-64)
src/plugin.cpp (+1/-1)
src/session.cpp (+3/-3)
Related bugs
Related blueprints
Branch information
Recent revisions
- 3010. By Sam Spilsbury
-
Check for the existence of screen since there's a condition where its
not around while CompOption's are being destroyed (bah coupling) - 3008. By Sam Spilsbury
-
Don't initialize to list size zero since that creates a temporary and destroys it
(for gosh knows what reasons) - 3005. By Sam Spilsbury
-
Only call removeAction on the CompOption destructor and not the CompOption::Value
destructor, since plugins that make copies of CompOption::Value can cause actions to
be added through setOptionForPlugin and then those actions will be removed when the
value temporary goes away.The action adding and removing only happens within the bounds of CompOption anyways, so
its its more appropriate to have it in its destructor.Of course, this brings up another issue, which is that CompOption should be noncopyable
but this opens up a whole another can of worms.How this even worked before is beyond me...
LP #931927
- 3004. By Sam Spilsbury
-
Remove finiScreenOptio
nValue and finiOptionValue There's no reason for these to exist
- 3003. By Sam Spilsbury
-
Fix typo which caused build failure. Merge lp:~smspillaz/compiz-core/compiz-core.fix_933226 into lp:compiz-core
- 3002. By Daniel van Vugt
-
Add support for key "tap" detection. A "tap" is when a key is pressed and released without any other key/button press occurring in between. (LP: #925293)
For example, if you have bound to the Alt key:
This will trigger a tap action:
Press Alt
Release AltThis will NOT trigger a tap action:
Press Alt
Press F
Release F
Release AltAn example of how to subscribe to taps has been added to the water plugin. If you want to test taps on modifier keys however you will also need to edit water.xml.in where it is commented.
Essentially, if your Terminate callback has both state bits set:
CompAction::StateTermKey
CompAction::StateTermTappe d
then you can be sure the key was tapped and not used as a modifier of another key.Fixes LP#925293
Merge lp:~vanvugt/compiz-core/fix-925293 into lp:compiz-core
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:compiz-core