Code review comment for lp:~smspillaz/compiz-core/compiz-core.fix_931927

Revision history for this message
Tim Penhey (thumper) wrote :

Please also change the constructor in noOptions too:

  static CompOption::Vector v (0);

should be:

  static CompOption::Vector v;

Given that there were also issues around the ordering of the static object initialisation that Sam said he saw, I'm in favour of landing this branch. However, we should look to clean the whole mess up soonish.

I want to know though what the impact is of making these constants.

review: Needs Fixing

« Back to merge proposal