Code review comment for lp:~smspillaz/compiz-core/compiz-core.fix_931927

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

> *** Found the problem ***
>
> CompOption::Vector noOptions (0);
> causes a reserve of at least one CompOption to be constructed (and then
> quickly destructed)
>
> The fix is to change:
> CompOption::Vector noOptions (0);
> to:
> CompOption::Vector noOptions;

It is still better to use the on-demand construction, for reasons specified above. I'll fix this though.

« Back to merge proposal