Code review comment for lp:~smspillaz/compiz-core/compiz-core.fix_931927

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The noOptions API change makes me nervous. Especially the part about returning a reference to a static local:

203 +CompOption::Vector &
204 +noOptions ()
205 +{
206 + static CompOption::Vector v (0);
207 + return v;
208 +}

Why not just change the global:
    CompOption::Vector noOptions (0);
to:
    const CompOption::Vector noOptions (0);
??

review: Needs Information

« Back to merge proposal