Code review comment for lp:~smoser/maas-images/trunk.v3-formatting

Revision history for this message
Lee Trager (ltrager) wrote :

The reason I changed formats is because the new kernel names are causing many lines to go way over the standard 80 character limit.

The longest line we'll have in a release is

 - [xenial, arm64, hwe-rolling-lowlatency-edge, lowlatency, linux-hwe-rolling-lowlatency-edge, *sa_hwe_x]

Which is 105 characters. I can live with that in the release section but I'm concerned about the growing subarch anchor section. Once Yakkety is released with all kernels we'll have

 - &sa_hwe_y [generic, hwe-p, hwe-q, hwe-r, hwe-s, hwe-t, hwe-u, hwe-v, hwe-w, hwe-16.04, hwe-16.04-edge, hwe-16.04-lowlatency, hwe-16.04-lowlatency-edge, hwe-16.10, hwe-16.10-edge, hwe-16.10-lowlatency, hwe-16.10-lowlatency-edge, hwe-rolling, hwe-rolling-edge, hwe-rolling-lowlatency, hwe-rolling-lowlatency-edge]

That is 314 characters and for each new release we'll be adding an additional 76 characters.

I suggest we compromise and keep the subarch anchors each on its own line while condensing the releases vertically.

review: Needs Information

« Back to merge proposal