Code review comment for lp:~smoser/curtin/trunk.snap-curtin-helpers

Revision history for this message
Scott Moser (smoser) wrote :

I disagree on two points.
a.) the existing interface is fine and consistent.
If you pass a value for a parameter, then you change behavior for that.
These things do what you want:
 get_paths()
 get_paths(lib="my-lib")
 get_paths(lib=None)

If you pass non-default you get non-default behavior. that is quite common.

b.) I don't agree with changing unrelated behaviors when fixing bugs. You are welcome to suggest that in a merge proposal of your own, but behavior changes do not belong as "tag alongs".

I'm willing to just do this because I'm annoyed by arguing, though.

« Back to merge proposal