lp:~smoser/curtin/trunk.snap-curtin-helpers

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~curtin-dev/curtin/trunk at revision 551

Ryan Harper (community): Approve on 2017-12-08

Server Team CI bot: Approve (continuous-integration) on 2017-12-07

Diff: 62 lines (+26/-8)

1 file modified

curtin/util.py (+26/-8)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

551. By Scott Moser on 2017-12-07

merge with trunk

550. By Scott Moser on 2017-12-07

update per ryan feedback

549. By Scott Moser on 2017-12-06

pack: fix packing when curtin is installed inside a snap.

When curtin is installed as part of a MAAS snap, then it would fail
to find its helpers directory. That is because instead of helpers
living in usr/lib/curtin/helpers they will be in
 /snap/maas/<version>/usr/lib/curtin/helpers
But helpfully, SNAP will be set in the environment to point to
 /snap/maas/<version>/

The fix is to adjust pack to consider trust the environment variable
and pack up the installed files based on that prefix.

548. By Ryan Harper on 2017-11-30

vmtests: exercise rootfs over an lvm logical volume

- modify mkfs to handle key=value parameter replacement for mkfs.xfs to
  control the uuid value of the filesystem
- Allow templating of the lvmroot yamls to specify different rootfs format
  types. This allow for testing with multiple fstypes without duplicating
  input yaml
- Fix a lurking CURTIN_REUSE_TOPDIR=1 bug under uefi mode where we attempt
  to rewrite grub.conf always
- Add a specific uefi_lvmroot configuration to match user issue from
  Bug #1731490
- Update vgcreate, lvcreate invocations to zero and wipe target devices
  and volumes where possible (> trusty) which eliminates the scary
  warning about detecting filesystem signatures on lv creation.

547. By Ryan Harper on 2017-11-30

Switch network dep filter to test for ifupdown/nplan instead of release name

Curtin will install some additional packages in-target depending on the
configuration. For example, if the curtin config includes bridges,
then it will ensure that bridge-utils is installed. These deps are
valid for releases using ifupdown. In Artful and newer (Bionic) netplan
is used instead and these tools are not needed.

This patch changes a release based check to a package install check.
If a system does not have ifupdown and also has netplan (nplan package)
then it will NOT install any ifupdown related deps (bridge-utils, vlan,
ifenslave).

546. By Ryan Harper on 2017-11-28

Allow control of curtin install unmounting

A Curtin install always unmounts the target. In the subiquity use-case
they would like to support a) if something goes wrong give a shell to
the user to poke around in the target b) skip unmounting automatically
to allow writing of additional files in the target without re-invoking
curtin c) control where curtin mounts up storage devices.

This branch adds two fields to the curtin 'install' config key: The
'target' value is a path that will be used instead of a temporary
directory. The 'unmount' key if found to be present and has the value
of 'disabled' then curtin install will skip the unmount operation.

Additionally to aid in unmounting a target outside of the install
subcommand this branch introduces a curtin 'unmount' subcommand which
takes two params: the 'target' path to the mount point, the default
'target' value is to use the TARGET_MOUNT_POINT environment variable.
Curtin will by default do unmounts in a recursive manner meaning any
directory mounted underneath the target will also be unmounted. A user
may supply '--disable-recursive-mounts' as a flag which will disable
the recursion resulting in a single unmount operation.

545. By Scott Moser on 2017-11-28

vmtests: Add Bionic release to tests and update classes.

544. By Ryan Harper on 2017-11-27

storage: add 'options' key mount type to specify mount parameters for filesystems

Add support, documentation, unittests and vmtests to deliver a new parameter to
the mount configuration dictionary. This parameter if set will modify the the
mount options field in the rendered /etc/fstab.

LP: #1709284

543. By Ryan Harper on 2017-11-27

Re-add curthooks.write_files method for backwards compat

In revno 512, curthooks.write_files() was re-implemented under
curtin.futil.write_files and supports the original dictionary
format as well as other modes. This broke legacy images which used
hooks that invoked curthooks.write_files. This branch restores
the function and behavior while utilizing the change in implementation.

- Add warning when legacy path is called pointing to new module location
- Add unittests to exercise the code path.

LP: #1731709

542. By Scott Moser on 2017-11-21

vmtest: Remove ArtfulTestBridging skip_by_date check, bug fixed

Bug 1721157 is now fixed, so do not need to skip by date anymore.