Code review comment for lp:~smoser/curtin/trunk.pylint-1.7

Revision history for this message
Ryan Harper (raharper) wrote :

I think we realized that pylint wasn't being run against tests/unittests
which is where those add_patch() methods come into play.
I think we should add tests/unittests to both py3-pylint and py27-pylint
and then add a .pylintrc like we have in cloud-init to handle
the generated-members and other settings we need to pass.

On Thu, Dec 7, 2017 at 11:26 AM, Scott Moser <email address hidden>
wrote:

> Ryan, we dont see the errors... I dont see them here and neither does c-i.
> I'd rather not add stuff to .tox if it doesn't seem needed.
>
> Make sense?
>
> --
> https://code.launchpad.net/~smoser/curtin/trunk.pylint-1.7/+merge/334851
> Your team curtin developers is requested to review the proposed merge of
> lp:~smoser/curtin/trunk.pylint-1.7 into lp:curtin.
>

« Back to merge proposal