Merge lp:~smoser/curtin/trunk.pylint-1.7 into lp:~curtin-dev/curtin/trunk

[Scott Moser]

tox: move to pylint 1.7.4

Update the pylint version used in tox from 1.5.4 to 1.7.4.
The primary gain from this is the ability to run with python3.6.
  https://github.com/PyCQA/pylint/issues/1113

[Ryan Harper (raharper)]

Need to update .pylintrc with

generated-members=m_.*,mock_.*

The add_patch() methods introduce dynamic attributes that pylint 1.7.1 barfs on.

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:550
https://jenkins.ubuntu.com/server/job/curtin-ci/693/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/693
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/693
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/693
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/693

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/693/rebuild

review: Approve (continuous-integration)

[Scott Moser (smoser)]

Ryan, we dont see the errors... I dont see them here and neither does c-i.
I'd rather not add stuff to .tox if it doesn't seem needed.

Make sense?

[Ryan Harper (raharper)]

I think we realized that pylint wasn't being run against tests/unittests
which is where those add_patch() methods come into play.
I think we should add tests/unittests to both py3-pylint and py27-pylint
and then add a .pylintrc like we have in cloud-init to handle
the generated-members and other settings we need to pass.

On Thu, Dec 7, 2017 at 11:26 AM, Scott Moser <email address hidden>
wrote:

> Ryan, we dont see the errors... I dont see them here and neither does c-i.
> I'd rather not add stuff to .tox if it doesn't seem needed.
>
> Make sense?
>
> --
> https://code.launchpad.net/~smoser/curtin/trunk.pylint-1.7/+merge/334851
> Your team curtin developers is requested to review the proposed merge of
> lp:~smoser/curtin/trunk.pylint-1.7 into lp:curtin.
>

[Ryan Harper (raharper)]

For now, lets land this and we can add unittests and see what breaks.

review: Approve

=== modified file 'tox.ini'
--- tox.ini	2017-02-10 17:49:31 +0000
+++ tox.ini	2017-12-06 19:05:57 +0000
@@ -43,7 +43,7 @@
 # set basepython because tox 1.6 (trusty) does not support generated environments
 basepython = python3
 deps = {[testenv]deps}
-    pylint==1.5.4
+    pylint==1.7.4
     bzr+lp:simplestreams
 commands = {envpython} -m pylint --errors-only {posargs:curtin tests/vmtests}
 
@@ -51,7 +51,7 @@
 # set basepython because tox 1.6 (trusty) does not support generated environments
 basepython = python2.7
 deps = {[testenv]deps}
-    pylint==1.5.4
+    pylint==1.7.4
 commands = {envpython} -m pylint --errors-only {posargs:curtin}
 
 [testenv:docs]