Merge ~smoser/cloud-init:fix/1796917-ignore-all-zero-macs into cloud-init:master
Proposed by
Scott Moser
Status: | Merged |
---|---|
Approved by: | Scott Moser |
Approved revision: | 3d91eaade62a6f427c948c40b6d0a618e6351311 |
Merge reported by: | Server Team CI bot |
Merged at revision: | not available |
Proposed branch: | ~smoser/cloud-init:fix/1796917-ignore-all-zero-macs |
Merge into: | cloud-init:master |
Diff against target: |
52 lines (+18/-2) 2 files modified
cloudinit/net/__init__.py (+4/-2) tests/unittests/test_net.py (+14/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Server Team CI bot | continuous-integration | Approve | |
Chad Smith | Approve | ||
Ryan Harper | Approve | ||
Review via email: mp+356342@code.launchpad.net |
Commit message
net: ignore nics that have "zero" mac address.
Previously we explicitly excluded mac address '00:00:
But then some nics (tunl0 and sit0) ended up having a mac address like
'00:00:00:00'.
The change here just ignores all 00[:00[:00...]].
LP: #1796917
Description of the change
see commit message
To post a comment you must log in.
Interesting, I was wondering why the output in the bug showed a "truncated" MAC. And I figured we would have already ignored empty MAC as well.
This looks good plus unittest!