Merge ~smoser/cloud-init:bddeb-release-arg into cloud-init:master

Proposed by Scott Moser
Status: Merged
Merged at revision: 2ddaa93b870bb0953a5a23b0eab155b21dd05a0f
Proposed branch: ~smoser/cloud-init:bddeb-release-arg
Merge into: cloud-init:master
Diff against target: 62 lines (+11/-4)
2 files modified
packages/bddeb (+10/-3)
packages/debian/changelog.in (+1/-1)
Reviewer Review Type Date Requested Status
Ryan Harper Approve
Review via email: mp+304563@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ryan Harper (raharper) wrote :

Nice, maybe a comment somewhere that shows how to put it together for PPA upload:

./packages/bddeb -S --sign --release=yakkety
dput ppa:foo cloud-init-<version>*source.changes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/packages/bddeb b/packages/bddeb
index 94496c7..abb7b60 100755
--- a/packages/bddeb
+++ b/packages/bddeb
@@ -67,7 +67,7 @@ def run_helper(helper, args=None, strip=True):
67 return stdout67 return stdout
6868
6969
70def write_debian_folder(root, version_data, pkgmap, pyver="3",70def write_debian_folder(root, templ_data, pkgmap, pyver="3",
71 append_requires=[]):71 append_requires=[]):
72 deb_dir = util.abs_join(root, 'debian')72 deb_dir = util.abs_join(root, 'debian')
7373
@@ -79,7 +79,7 @@ def write_debian_folder(root, version_data, pkgmap, pyver="3",
79 templater.render_to_file(util.abs_join(find_root(),79 templater.render_to_file(util.abs_join(find_root(),
80 'packages', 'debian', 'changelog.in'),80 'packages', 'debian', 'changelog.in'),
81 util.abs_join(deb_dir, 'changelog'),81 util.abs_join(deb_dir, 'changelog'),
82 params=version_data)82 params=templ_data)
8383
84 # Write out the control file template84 # Write out the control file template
85 reqs = run_helper('read-dependencies').splitlines()85 reqs = run_helper('read-dependencies').splitlines()
@@ -147,6 +147,10 @@ def main():
147 default=os.environ.get("INIT_SYSTEM",147 default=os.environ.get("INIT_SYSTEM",
148 "upstart,systemd"))148 "upstart,systemd"))
149149
150 parser.add_argument("--release", dest="release",
151 help=("build with changelog referencing RELEASE"),
152 default="UNRELEASED")
153
150 for ent in DEBUILD_ARGS:154 for ent in DEBUILD_ARGS:
151 parser.add_argument(ent, dest="debuild_args", action='append_const',155 parser.add_argument(ent, dest="debuild_args", action='append_const',
152 const=ent, default=[],156 const=ent, default=[],
@@ -184,6 +188,7 @@ def main():
184 pkgmap[p] = "python3-" + p188 pkgmap[p] = "python3-" + p
185 pyver = "3"189 pyver = "3"
186190
191 templ_data = {'debian_release': args.release}
187 with util.tempdir() as tdir:192 with util.tempdir() as tdir:
188193
189 # output like 0.7.6-1022-g36e92d3194 # output like 0.7.6-1022-g36e92d3
@@ -208,7 +213,9 @@ def main():
208 append_requires = ['cloud-utils | cloud-guest-utils']213 append_requires = ['cloud-utils | cloud-guest-utils']
209 else:214 else:
210 append_requires = []215 append_requires = []
211 write_debian_folder(xdir, ver_data, pkgmap,216
217 templ_data.update(ver_data)
218 write_debian_folder(xdir, templ_data, pkgmap,
212 pyver=pyver, append_requires=append_requires)219 pyver=pyver, append_requires=append_requires)
213220
214 print("Running 'debuild %s' in %r" % (' '.join(args.debuild_args),221 print("Running 'debuild %s' in %r" % (' '.join(args.debuild_args),
diff --git a/packages/debian/changelog.in b/packages/debian/changelog.in
index f8e9825..bdf8d56 100644
--- a/packages/debian/changelog.in
+++ b/packages/debian/changelog.in
@@ -1,5 +1,5 @@
1## template:basic1## template:basic
2cloud-init (${version_long}-1~bddeb) UNRELEASED; urgency=low2cloud-init (${version_long}-1~bddeb) ${debian_release}; urgency=low
33
4 * build4 * build
55

Subscribers

People subscribed via source and target branches