Merge ~smoser/cloud-init:bddeb-release-arg into cloud-init:master

Proposed by Scott Moser
Status: Merged
Merged at revision: 2ddaa93b870bb0953a5a23b0eab155b21dd05a0f
Proposed branch: ~smoser/cloud-init:bddeb-release-arg
Merge into: cloud-init:master
Diff against target: 62 lines (+11/-4)
2 files modified
packages/bddeb (+10/-3)
packages/debian/changelog.in (+1/-1)
Reviewer Review Type Date Requested Status
Ryan Harper Approve
Review via email: mp+304563@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ryan Harper (raharper) wrote :

Nice, maybe a comment somewhere that shows how to put it together for PPA upload:

./packages/bddeb -S --sign --release=yakkety
dput ppa:foo cloud-init-<version>*source.changes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/packages/bddeb b/packages/bddeb
2index 94496c7..abb7b60 100755
3--- a/packages/bddeb
4+++ b/packages/bddeb
5@@ -67,7 +67,7 @@ def run_helper(helper, args=None, strip=True):
6 return stdout
7
8
9-def write_debian_folder(root, version_data, pkgmap, pyver="3",
10+def write_debian_folder(root, templ_data, pkgmap, pyver="3",
11 append_requires=[]):
12 deb_dir = util.abs_join(root, 'debian')
13
14@@ -79,7 +79,7 @@ def write_debian_folder(root, version_data, pkgmap, pyver="3",
15 templater.render_to_file(util.abs_join(find_root(),
16 'packages', 'debian', 'changelog.in'),
17 util.abs_join(deb_dir, 'changelog'),
18- params=version_data)
19+ params=templ_data)
20
21 # Write out the control file template
22 reqs = run_helper('read-dependencies').splitlines()
23@@ -147,6 +147,10 @@ def main():
24 default=os.environ.get("INIT_SYSTEM",
25 "upstart,systemd"))
26
27+ parser.add_argument("--release", dest="release",
28+ help=("build with changelog referencing RELEASE"),
29+ default="UNRELEASED")
30+
31 for ent in DEBUILD_ARGS:
32 parser.add_argument(ent, dest="debuild_args", action='append_const',
33 const=ent, default=[],
34@@ -184,6 +188,7 @@ def main():
35 pkgmap[p] = "python3-" + p
36 pyver = "3"
37
38+ templ_data = {'debian_release': args.release}
39 with util.tempdir() as tdir:
40
41 # output like 0.7.6-1022-g36e92d3
42@@ -208,7 +213,9 @@ def main():
43 append_requires = ['cloud-utils | cloud-guest-utils']
44 else:
45 append_requires = []
46- write_debian_folder(xdir, ver_data, pkgmap,
47+
48+ templ_data.update(ver_data)
49+ write_debian_folder(xdir, templ_data, pkgmap,
50 pyver=pyver, append_requires=append_requires)
51
52 print("Running 'debuild %s' in %r" % (' '.join(args.debuild_args),
53diff --git a/packages/debian/changelog.in b/packages/debian/changelog.in
54index f8e9825..bdf8d56 100644
55--- a/packages/debian/changelog.in
56+++ b/packages/debian/changelog.in
57@@ -1,5 +1,5 @@
58 ## template:basic
59-cloud-init (${version_long}-1~bddeb) UNRELEASED; urgency=low
60+cloud-init (${version_long}-1~bddeb) ${debian_release}; urgency=low
61
62 * build
63

Subscribers

People subscribed via source and target branches