Launchpad itself

Code review comment for lp:~sinzui/launchpad/wax-and-wane

  1. wax-and-wane
  2. Merge into devel
Revision history for this message
Brad Crittenden (bac) wrote :

Hi Curtis,

Thanks for these changes. Everything looks really good. I would suggest you put a test into _append_paragraph to ensure current_paragraph is not empty. This could happen if you closed the paragraph right before you hit line 20. It's not big deal but we shouldn't generate an empty <p></p> if we can easily help it.

review: Approve (code)

« Back to merge proposal